Enable private addresses for ICE based on a per-endpoint flag. #2047
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2047 +/- ##
============================================
+ Coverage 42.75% 42.76% +0.01%
Complexity 1684 1684
============================================
Files 325 325
Lines 17144 17155 +11
Branches 2253 2255 +2
============================================
+ Hits 7330 7337 +7
- Misses 9098 9102 +4
Partials 716 716 Continue to review full report in Codecov by Sentry.
|
| private fun LocalCandidate.toCandidatePacketExtension(advertisePrivateAddresses: Boolean): CandidatePacketExtension? { | ||
| if (!(advertisePrivateAddresses && IceConfig.config.advertisePrivateCandidates) && | ||
| transportAddress.isPrivateAddress() | ||
| ) { |
There was a problem hiding this comment.
I think this logic is wrong?
| @@ -255,7 +255,8 @@ videobridge { | |||
| # "NominateFirstValid", "NominateHighestPriority", "NominateFirstHostOrReflexiveValid", or "NominateBestRTT". | |||
| nomination-strategy = "NominateFirstHostOrReflexiveValid" | |||
|
|
|||
| # Whether to advertise private ICE candidates, i.e. RFC 1918 IPv4 addresses and fec0::/10 and fc00::/7 IPv6 addresses. | |||
| # Whether to advertise private ICE candidates, i.e. RFC 1918 IPv4 addresses and fec0::/10 and fc00::/7 IPv6 | |||
| # addresses for endpoints that have signaled support for private addresses. | |||
There was a problem hiding this comment.
You made the existing advertise-private-candidates config flag mean "advertise private addresses if jicofo requests it", which changes the current behavior -- I think we want it to be "advertise private candidates even if jicofo doesn't request it" to keep compatibility for community users setting the flag today (e.g. running entirely in a private network).
| @@ -167,7 +167,7 @@ class Relay @JvmOverloads constructor( | |||
| private val sctpHandler = SctpHandler() | |||
| private val dataChannelHandler = DataChannelHandler() | |||
|
|
|||
| private val iceTransport = IceTransport(id, iceControlling, useUniquePort, logger, clock) | |||
| private val iceTransport = IceTransport(id, iceControlling, useUniquePort, true, logger, clock) | |||
There was a problem hiding this comment.
Add a comment what this "true" means
No description provided.