Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for video described by the AV1 Dependency Descriptor #1998

Merged
merged 151 commits into from
Nov 2, 2023
Merged

Support for video described by the AV1 Dependency Descriptor #1998

merged 151 commits into from
Nov 2, 2023

Conversation

JonathanLennox
Copy link
Member

No description provided.

@JonathanLennox
Copy link
Member Author

See also #1996

@codecov
Copy link

codecov bot commented Feb 23, 2023 •
edited
Loading

Codecov Report

Merging #1998 (453dcc4) into master (30dcf51) will increase coverage by 1.75%.
Report is 6 commits behind head on master.
The diff coverage is 57.67%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1998      +/-   ##
============================================
+ Coverage     42.48%   44.23%   +1.75%     
- Complexity     1663     1924     +261     
============================================
  Files           325      340      +15     
  Lines         17142    18879    +1737     
  Branches       2239     2592     +353     
============================================
+ Hits           7282     8351    +1069     
- Misses         9153     9663     +510     
- Partials        707      865     +158
Files Coverage Δ
...nsform/src/main/kotlin/org/jitsi/nlj/PacketInfo.kt 27.39% <ø> (ø)
...rc/main/kotlin/org/jitsi/nlj/codec/vpx/VpxUtils.kt 85.71% <100.00%> (ø)
...rm/src/main/kotlin/org/jitsi/nlj/dtls/DtlsUtils.kt 58.40% <ø> (ø)
...rc/main/kotlin/org/jitsi/nlj/dtls/TlsClientImpl.kt 66.66% <100.00%> (ø)
...rc/main/kotlin/org/jitsi/nlj/rtp/AudioRtpPacket.kt 100.00% <100.00%> (ø)
...main/kotlin/org/jitsi/nlj/rtp/ParsedVideoPacket.kt 100.00% <100.00%> (ø)
...src/main/kotlin/org/jitsi/nlj/rtp/RtpExtensions.kt 100.00% <100.00%> (ø)
...main/kotlin/org/jitsi/nlj/rtp/TransportCcEngine.kt 78.47% <100.00%> (+0.30%) ⬆️
...c/main/kotlin/org/jitsi/nlj/transform/node/Node.kt 57.72% <ø> (ø)
...ransform/node/incoming/RemoteBandwidthEstimator.kt 71.66% <100.00%> (ø)
... and 99 more

... and 8 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be7701f...453dcc4. Read the comment docs.

J000Z
J000Z reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor

@J000Z J000Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@ProdigyView
Copy link

Does this mean AV1 will work?

@JonathanLennox
Copy link
Member Author

Does this mean AV1 will work?

When it's done, that's the goal. This is still a work in progress.

@ProdigyView ProdigyView mentioned this pull request Mar 5, 2023
Closed
bgrozev
bgrozev reviewed Mar 8, 2023
View reviewed changes
...rc/main/kotlin/org/jitsi/rtp/rtp/header_extensions/Av1DependencyDescriptorHeaderExtension.kt Outdated Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/MediaSourceDesc.kt Outdated Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/MediaSourceDesc.kt Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/rtp/VideoRtpPacket.kt Outdated Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/rtp/codec/vp8/Vp8Packet.kt Outdated Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/rtp/codec/vp9/Vp9Packet.kt Outdated Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/RtpLayerDesc.kt Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/util/TreeCache.kt Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/rtp/codec/vpx/VpxRtpLayerDesc.kt Outdated Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/rtp/codec/vpx/VpxRtpLayerDesc.kt Outdated Show resolved Hide resolved
@JonathanLennox
Pass only encodingId to AdaptiveSourceProjectionContext.accept() rath…
094b97b 
…er than setOf(layerId).

In almost all cases the encodingId is the only thing the contexts use from the layer IDs, and in those few cases
they can compute the remaining information from the packet.
@JonathanLennox
Log improvements.
2d02a32
@JonathanLennox
Add DumpAv1DependencyDescriptor tool to print AV1 DDs as JSON.
c182e17
@JonathanLennox
Merge branch 'master' into av1-dd
a87aa3d
@JonathanLennox
Keep track of the "nominal height" of an encoding.
a596571 
Apply it to newly-set layer sets when appropriate.

Handles the case that Chrome doesn't send resolutions in AV1 DD for multi-encoding simulcast.
@JonathanLennox
Handle all spatial layers being unknown in getNominalHeight.
78f47eb
@JonathanLennox
Move layer height assignment to the right place.
6ce057a
@JonathanLennox
Merge branch 'master' into av1-dd
92e3a0a
@jallamsetty1 jallamsetty1 mentioned this pull request Sep 13, 2023
Merged
@bgrozev bgrozev marked this pull request as ready for review October 31, 2023 19:31
bgrozev
bgrozev previously approved these changes Nov 1, 2023
View reviewed changes
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/RtpEncodingDesc.kt Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/RtpEncodingDesc.kt Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/RtpLayerDesc.kt Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/rtp/codec/av1/Av1DDPacket.kt Show resolved Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/rtp/codec/av1/Av1DDPacket.kt Show resolved Hide resolved
jvb/src/main/kotlin/org/jitsi/videobridge/cc/av1/Av1DDQualityFilter.kt Show resolved Hide resolved
jvb/src/main/kotlin/org/jitsi/videobridge/cc/av1/Av1DDQualityFilter.kt Outdated Show resolved Hide resolved
jvb/src/main/kotlin/org/jitsi/videobridge/cc/av1/Av1DDQualityFilter.kt Show resolved Hide resolved
jvb/src/main/kotlin/org/jitsi/videobridge/cc/av1/Av1DDQualityFilter.kt Show resolved Hide resolved
jvb/src/main/kotlin/org/jitsi/videobridge/cc/av1/Av1DDFrameProjection.kt Outdated Show resolved Hide resolved
bgrozev
bgrozev previously approved these changes Nov 2, 2023
View reviewed changes
@JonathanLennox JonathanLennox merged commit 7a4dc8b into jitsi:master Nov 2, 2023
5 checks passed
@bgrozev bgrozev mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J000Z J000Z J000Z left review comments

@bgrozev bgrozev bgrozev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JonathanLennox @ProdigyView @VernPace @bgrozev @J000Z