Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cryptex. #1969

Merged
merged 11 commits into from
Feb 17, 2023
Merged

Support cryptex. #1969

merged 11 commits into from
Feb 17, 2023

Conversation

JonathanLennox
Copy link
Member

Supports draft-ietf-avtcore-cryptex. Part of a package with jitsi/jitsi-srtp#29, jitsi/lib-jitsi-meet#2150, and jitsi/jitsi-xmpp-extensions#87.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1969 (c80753a) into master (f6426ea) will decrease coverage by 0.08%.
The diff coverage is 18.57%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1969      +/-   ##
============================================
- Coverage     43.10%   43.02%   -0.08%     
+ Complexity     1668     1667       -1     
============================================
  Files           322      323       +1     
  Lines         16691    16721      +30     
  Branches       2192     2200       +8     
============================================
+ Hits           7194     7195       +1     
- Misses         8788     8824      +36     
+ Partials        709      702       -7     
Impacted Files Coverage Δ
...m/src/main/kotlin/org/jitsi/nlj/RtpReceiverImpl.kt 0.00% <0.00%> (ø)
...sform/src/main/kotlin/org/jitsi/nlj/Transceiver.kt 0.00% <0.00%> (ø)
...n/kotlin/org/jitsi/nlj/transform/node/RtpParser.kt 0.00% <0.00%> (ø)
...si/nlj/transform/node/incoming/AudioLevelReader.kt 0.00% <0.00%> (ø)
...nsform/src/main/kotlin/org/jitsi/nlj/PacketInfo.kt 28.57% <25.00%> (+0.21%) ⬆️
.../jitsi/videobridge/transport/dtls/DtlsTransport.kt 34.14% <33.33%> (-0.04%) ⬇️
.../src/main/kotlin/org/jitsi/videobridge/Endpoint.kt 20.30% <40.00%> (-0.11%) ⬇️
...c/main/kotlin/org/jitsi/videobridge/relay/Relay.kt 18.03% <40.00%> (+0.05%) ⬆️
...orm/src/main/kotlin/org/jitsi/nlj/srtp/SrtpUtil.kt 54.54% <100.00%> (+0.37%) ⬆️
...ransform/node/incoming/RemoteBandwidthEstimator.kt 70.17% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6426ea...c80753a. Read the comment docs.

@JonathanLennox JonathanLennox marked this pull request as ready for review February 16, 2023 21:34
@JonathanLennox
Copy link
Member Author

I marked this as "ready for review" but we still need the AudioLevelReader split.

@@ -771,6 +773,9 @@ class Endpoint @JvmOverloads constructor(
} else {
logger.info("Ignoring empty DtlsFingerprint extension: ${transportInfo.toXML()}")
}
if (CryptexConfig.endpoint) {
cryptex = cryptex || fingerprintExtension.cryptex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be && now? Otherwise it's just equivalent to the config value. The semantics of Endpoint.cryptex is "whether we should use cryptex when encrypting", right?

@JonathanLennox JonathanLennox merged commit 1a00812 into jitsi:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants