-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps) bump excalidraw version #14641
Conversation
Shall we ditch the source map in this case, @saghul? |
The source map should be a separate file, just like other bundles. |
It is, then I'm not sure what causes the huge bump in the app.bundle entrypoint size.. Can I just update the performance values? |
No way we are almost tripling the size. Check with the webpack bundle analyzer. It shows a nice visual which would reveal where the size increase comes from. |
package.json
Outdated
@@ -179,7 +179,7 @@ | |||
"typescript": "5.0.4", | |||
"unorm": "1.6.0", | |||
"webpack": "5.76.0", | |||
"webpack-bundle-analyzer": "4.4.2", | |||
"webpack-bundle-analyzer": "^4.4.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please drop the caret
Is the bundle size issue fixed? And we get source maps? Exciting! |
No.. I just thought to get the fix in to catch the release asap. I'll get on the bundle size too |
No description provided.