Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps) bump excalidraw version #14641

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

mihhu
Copy link
Member

@mihhu mihhu commented Apr 16, 2024

No description provided.

@mihhu mihhu requested a review from saghul April 16, 2024 14:56
saghul
saghul previously approved these changes Apr 16, 2024
@mihhu
Copy link
Member Author

mihhu commented Apr 17, 2024

ERROR in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (5 MiB). This can impact web performance. 
33Entrypoints: 
34  app.bundle (12 MiB) 
35      app.bundle.min.js

Shall we ditch the source map in this case, @saghul?

@saghul
Copy link
Member

saghul commented Apr 17, 2024

The source map should be a separate file, just like other bundles.

@mihhu
Copy link
Member Author

mihhu commented Apr 17, 2024

It is, then I'm not sure what causes the huge bump in the app.bundle entrypoint size.. Can I just update the performance values?

@saghul
Copy link
Member

saghul commented Apr 17, 2024

No way we are almost tripling the size.

Check with the webpack bundle analyzer. It shows a nice visual which would reveal where the size increase comes from.

package.json Outdated
@@ -179,7 +179,7 @@
"typescript": "5.0.4",
"unorm": "1.6.0",
"webpack": "5.76.0",
"webpack-bundle-analyzer": "4.4.2",
"webpack-bundle-analyzer": "^4.4.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the caret

@saghul
Copy link
Member

saghul commented May 8, 2024

Is the bundle size issue fixed? And we get source maps? Exciting!

@mihhu mihhu force-pushed the excalidraw-0.0.18 branch from 2c4f2d5 to 6b061b9 Compare May 8, 2024 10:38
@mihhu mihhu force-pushed the excalidraw-0.0.18 branch from 6b061b9 to f59e960 Compare May 8, 2024 10:39
@mihhu
Copy link
Member Author

mihhu commented May 8, 2024

Is the bundle size issue fixed? And we get source maps? Exciting!

No.. I just thought to get the fix in to catch the release asap. I'll get on the bundle size too

@mihhu mihhu merged commit 50d4b62 into jitsi:master May 8, 2024
9 checks passed
@mihhu mihhu deleted the excalidraw-0.0.18 branch May 8, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants