Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prosody plugin for sending system chat messages #14603

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

quitrk
Copy link
Contributor

@quitrk quitrk commented Apr 8, 2024

No description provided.

@quitrk quitrk force-pushed the tavram/send-system-chat branch from 846a14e to 74e20cb Compare April 8, 2024 11:19
@quitrk quitrk requested review from saghul and damencho April 8, 2024 11:19
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Left some comments, PTAL. @damencho can you PTAL at the Prosody code too please?

react/features/chat/constants.ts Outdated Show resolved Hide resolved
resources/prosody-plugins/mod_muc_system_chat_message.lua Outdated Show resolved Hide resolved
resources/prosody-plugins/mod_muc_system_chat_message.lua Outdated Show resolved Hide resolved
resources/prosody-plugins/mod_muc_system_chat_message.lua Outdated Show resolved Hide resolved
@quitrk quitrk force-pushed the tavram/send-system-chat branch from 0d4b4b2 to fd3f0b3 Compare April 8, 2024 13:14
saghul
saghul previously approved these changes Apr 8, 2024
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pl wait for @damencho 's feedback before merging.

@quitrk quitrk merged commit 097d51c into master Apr 8, 2024
8 checks passed
@quitrk quitrk deleted the tavram/send-system-chat branch April 8, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants