fix(lang) (a11y) update screen reader related french translation #14565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- settings string contained a string saying "show / hide settings", but we should match the english string saying only "show settings" as the button is only used to show the settings (its a dialog you can't go out of, so there is no way to go back to the settings button to close, the "hide" case doesn't exist) - use "Activer" instead of "Rétablir" and "Démarrer" for toggle on states, as this wording is used accross lots of other buttons, it makes more sense to use the same wording - change the unmute/mute audio/video strings to tell the user its *their* device they toggle. There are a few spots in this app where we label stuff as "mute microphone", sometimes its for you, sometimes its for other people. The idea here is to say "Mute your microphone" instead of "Mute microphone" so that screen reader users fully understand what they do.
|
Hi, thanks for your contribution! |
|
Hey, anything I'm required to do so that this is merged @saghul? Signed the CLA last year ;) Thanks! |
damencho
approved these changes
May 13, 2024
|
Thanks for merging! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Here a couple changes on french translations. The unmute/mute string changes are quite important, as for now, french screen reader users don't get the info about the current state. The button is vocalized as "Mute/unmute mic", but you don't get the info about if it's muted on press, or on unpressed. So this tiny translation change has a huge impact for french screen reader users.
The changes explained in details:
settings string contained a string saying "show / hide settings", but we should match the english string saying only "show settings" as the button is only used to show the settings (its a dialog you can't go out of, so there is no way to go back to the settings button to close, the "hide" case doesn't exist)
use "Activer" instead of "Rétablir" and "Démarrer" for toggle on states, as this wording is used accross lots of other buttons, it makes more sense to use the same wording
change the unmute/mute audio/video strings to tell the user its their device they toggle. There are a few spots in this app where we label stuff as "mute microphone", sometimes its for you, sometimes its for other people. The idea here is to say "Mute your microphone" instead of "Mute microphone" so that screen reader users fully understand what they do.