fix(participant) prevent gravatar request during loading of config #14255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
previously approved these changes
Jan 19, 2024
|
🙏 |
|
Hi, thanks for your contribution! |
|
@saghul Sorry, I somehow manage to do syntax error in 1 line of code. |
|
Jenkins please test this please. |
|
@saghul Sorry, I feel like I need to do something else, but not sure what? |
saghul
approved these changes
Jan 24, 2024
|
All good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should probably fix #14249
PS I was thinking about adding "isConfigLoaded" property to fix this once and for all, but it seems to be quite dramatic change and I'm not very familiar with a code to make it properly, so rather just follow advice of @saghul and checking for a key which is known as mandatory