Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Russian translations #14213

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Updated Russian translations #14213

merged 5 commits into from
Jan 17, 2024

Conversation

ZXLTRXN
Copy link
Contributor

@ZXLTRXN ZXLTRXN commented Jan 10, 2024

Added some prases for ru locale which is necessary for using in mobile sdk.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

<string name="ongoing_notification_action_mute">Отключить звук</string>
<string name="ongoing_notification_action_unmute">Включить звук</string>
<string name="ongoing_notification_channel_name">Ongoing Conference Notifications</string>
</resources>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul do we add translations to the android resource values?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but it doesn't hurt either.

@damencho
Copy link
Member

Drop all empty translations, they would at least default to english.

@saghul
Copy link
Member

saghul commented Jan 15, 2024

A couple of comments, LGTM otherwise.

@saghul saghul merged commit 60d4b62 into jitsi:master Jan 17, 2024
7 checks passed
@saghul
Copy link
Member

saghul commented Jan 17, 2024

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants