Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moment duration format error #14190

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

oguzhanslmtemiz
Copy link
Contributor

Issue: When lobby mode is active, the ui showing the elapsed time gives an error when it comes to the screen. Moment just released a new update and moment-duration-format plugin is not compatible with this version. This plugin will always try to install itself on the root.moment instance, if it exists. source

Solution: Used the moment version of jitsi-meet instead of root. No problem with version 2.29.4

Simulator Screenshot - iPhone 15 - 2023-12-28 at 15 34 01

Simulator Screenshot - iPhone 15 - 2023-12-28 at 15 35 00

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

react/features/base/i18n/dateUtil.ts Outdated Show resolved Hide resolved
Copy link
Contributor Author

@oguzhanslmtemiz oguzhanslmtemiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor Author

@oguzhanslmtemiz oguzhanslmtemiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matched package dependency version exactly

@oguzhanslmtemiz oguzhanslmtemiz requested a review from saghul January 8, 2024 12:23
@saghul
Copy link
Member

saghul commented Jan 8, 2024

Jenkins please test this please.

@saghul saghul merged commit 3bde570 into jitsi:master Jan 8, 2024
8 checks passed
@saghul
Copy link
Member

saghul commented Jan 8, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants