-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: moment duration format error #14190
Conversation
Hi, thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matched package dependency version exactly
Jenkins please test this please. |
Thank you! |
Issue: When lobby mode is active, the ui showing the elapsed time gives an error when it comes to the screen. Moment just released a new update and moment-duration-format plugin is not compatible with this version. This plugin will always try to install itself on the root.moment instance, if it exists. source
Solution: Used the moment version of jitsi-meet instead of root. No problem with version 2.29.4