Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accessibility): Improve search input fields accessibility #14186

Merged

Conversation

mgcm
Copy link
Contributor

@mgcm mgcm commented Dec 27, 2023

This PR improves the accessibility of a couple of search fields:

  • adds an accessibility label to the Search Participants input text field in the Participants Pane
  • adds an accessibility label to the Search input text field in the Participants Stats dialog with added context and the associated translations

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@mgcm mgcm changed the title Improve search input fields accessibility feat(accessibility): mprove search input fields accessibility Dec 27, 2023
@mgcm mgcm changed the title feat(accessibility): mprove search input fields accessibility feat(accessibility): Improve search input fields accessibility Dec 27, 2023
Signed-off-by: Milton Moura <[email protected]>
@mgcm
Copy link
Contributor Author

mgcm commented Jan 5, 2024

@jallamsetty1 or @Calinteodor would it be possible to get a review on this? thanks!

@Calinteodor
Copy link
Contributor

Please jenkins test this please!

@mgcm
Copy link
Contributor Author

mgcm commented Jan 8, 2024

@Calinteodor seems like all checks have passed :)

@Calinteodor Calinteodor merged commit e697ee7 into jitsi:master Jan 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants