feat: Adds detection of occupants with no connection. #14146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw recently two occasions with rooms with participants but no prosody.full_sessions for those participants and when everyone leaves the meeting it never ends.
damencho
force-pushed
the
leak-room-detection
branch
from
b6e7996 to
534a64c
Compare
| @@ -37,6 +37,8 @@ local tostring = tostring; | |||
| -- required parameter for custom muc component prefix, defaults to "conference" | |||
| local muc_domain_prefix = module:get_option_string("muc_mapper_domain_prefix", "conference"); | |||
|
|
|||
| local leaked_rooms_since_last_stat = 0; | |||
There was a problem hiding this comment.
Suggested change
| local leaked_rooms_since_last_stat = 0; | |
| local leaked_rooms = 0; |
| @@ -49,15 +51,33 @@ function handle_get_room_census(event) | |||
| for room in host_session.modules.muc.each_room() do | |||
| if not is_healthcheck_room(room.jid) then | |||
| local occupants = room._occupants; | |||
| local participant_count = 0; | |||
| local missing_connections_count = 0; | |||
There was a problem hiding this comment.
Suggested change
| local missing_connections_count = 0; | |
| local missing_connections_count = 0; | |
| local current_leaked_rooms = 0; |
| local leaked = false; | ||
| if participant_count > 0 and missing_connections_count == participant_count then | ||
| leaked = true; | ||
| leaked_rooms_since_last_stat = leaked_rooms_since_last_stat + 1; |
There was a problem hiding this comment.
Suggested change
| leaked_rooms_since_last_stat = leaked_rooms_since_last_stat + 1; | |
| current_leaked_rooms = current_leaked_rooms + 1; |
| leaked = true; | ||
| leaked_rooms_since_last_stat = leaked_rooms_since_last_stat + 1; | ||
| end | ||
|
|
There was a problem hiding this comment.
Suggested change
| leaked_rooms = current_leaked_rooms |
| -- we calculate the stats on the configured interval (60 seconds by default) | ||
| local measure_leaked_rooms = module:measure('leaked_rooms', 'amount'); | ||
| module:hook_global('stats-update', function () | ||
| measure_leaked_rooms(leaked_rooms_since_last_stat); |
There was a problem hiding this comment.
Suggested change
| measure_leaked_rooms(leaked_rooms_since_last_stat); | |
| measure_leaked_rooms(leaked_rooms); |
| local measure_leaked_rooms = module:measure('leaked_rooms', 'amount'); | ||
| module:hook_global('stats-update', function () | ||
| measure_leaked_rooms(leaked_rooms_since_last_stat); | ||
| leaked_rooms_since_last_stat = 0; |
There was a problem hiding this comment.
Suggested change
| leaked_rooms_since_last_stat = 0; |
aaronkvanmeerten
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw recently two occasions with rooms with participants but no prosody.full_sessions for those participants and when everyone leaves the meeting it never ends.