Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): prejoin property. #14141

Closed
wants to merge 1 commit into from

Conversation

hristoterezov
Copy link
Member

No description provided.

@saghul
Copy link
Member

saghul commented Dec 11, 2023

Not a huge fan of the approach because it spreds across features and feels kinda brittle. Can't we use the same model as with wasLobbyVisible? It's initialized to false and then it's updated here:

@hristoterezov
Copy link
Member Author

Closed in favor of #14177.

@saghul I've tried the same approach as for the lobby for the prejoin property for mobile but it turned out there was potential issue with setting the permanant props before initialization of the analytics. Basically on init we would override all the values with the values from the init. All those are addressed now in the above PR. Could you PTAL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants