refactor: replace deprecated String.prototype.substr() #11190
Conversation
|
Hi, thanks for your contribution! |
|
Jenkins please test this please. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This PR is still relevant |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
THis needs a rebase. Sorry it fell through the cracks :-/ |
CommanderRoot
force-pushed
the
refactor/rm-deprecated-substr
branch
from
8673f9f to
63bd17e
Compare
|
I have rebased the commits as requested |
|
Jenkins please test this please. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <[email protected]>
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <[email protected]>
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <[email protected]>
CommanderRoot
force-pushed
the
refactor/rm-deprecated-substr
branch
from
63bd17e to
9576354
Compare
|
I have rebased the commits and resolved the merge conflicts |
|
Jenkins please test this please. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.