chore(deps) update Electron to 24 #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@csett86 WDYT about landing this and making a new release? We haven't done one in a bit... |
|
I'll take a look tomorrow. I was holding back the electron upgrade as it will break screensharing on wayland (segfault on trying), but as it does not seem to get fixed, I will add a bigger warning in the readme as a known issue together with this PR |
|
Thanks! Yeah that's unfortunate but 21 is EOLd so I think we have to upgrade. |
d3473r
pushed a commit
to d3473r/jitsi-meet-electron
that referenced
this pull request
Sep 1, 2023
* chore(deps) update Electron to 24 * docs: document broken screensharing on wayland See jitsi#829 --------- Co-authored-by: Christoph Settgast <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.