Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove a redundant call to updateEstimate(). #287

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Aug 25, 2020

No description provided.

@bgrozev
Copy link
Member Author

bgrozev commented Aug 25, 2020

There's a comment about reducing how often we call updateEstimate, and now it's called twice for every packet reported in TCC: once in GoogCcEstimator.doProcessPacketArrival and once inside updateReceiverBlock. I'm not sure which one it makes more sense to keep.
cc @JonathanLennox

edit: I just noticed there is an early return in the one in updateReceiverBlock, so we should keep the one outside (like in the PR).

@JonathanLennox
Copy link
Member

I think a better way to reduce the number of times we call updateEstimate() would be to implement the feedbackComplete part of my old PR #155 -- right now we call updateEstimate for each packet reported on in the TCC feedback.

I can look at that, or you can if you want, but in the meantime, this is probably fine.

@JonathanLennox
Copy link
Member

See my PR #291 for the code I mentioned.

I don't think that conflicts with this PR; we can and should do both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants