Apply RFC 7741 for VP8 #178
Conversation
L: TL0PICIDX present. When set to 1, the TL0PICIDX MUST be present and specified as below, and the T bit MUST be set to 1. Otherwise, TL0PICIDX MUST NOT be present. Add Y bit and KEYIDX value to be obtain Add Vp8 Key Frame validation Get Width and Height and their scaling values from Vp8 Payload Header
|
Hi, thanks for your contribution! |
| @@ -146,7 +162,54 @@ public static int getTemporalLayerIndex(byte[] buf, int off, int len) | |||
| return -1; | |||
| } | |||
|
|
|||
| return (buf[off + sz - 1] & 0xc0) >> 6; | |||
| return (byte) (buf[off + sz - 1] & 0xFF); | |||
There was a problem hiding this comment.
What does the & 0xFF do here? This is a byte.
There was a problem hiding this comment.
This makes sure that if regular value of the byte is greater than 127, then it won't change to negative values when converting to integer and back to byte
There was a problem hiding this comment.
But doesn't it convert to negative anyway when you cast to byte?
src/main/java/org/jitsi_modified/impl/neomedia/codec/video/vp8/DePacketizer.java
Outdated
Show resolved
Hide resolved
|
@lem21h : have you signed the Jitsi CLA? (Sorry if you already have, it's not obvious to me how to associate your github username with a name on a signed form.) |
|
Hi @JonathanLennox , I have signed. Please tell me how can I help you identify myself on that list ? |
|
@lem21h : just let me know the name you used when you signed? (If you don't want it publicly on GitHub, you can also e-mail it to me.) |
|
Jenkins, test this please. |
|
It would be great to have unit tests for these accessors (e.g. running on a VP8 packet captured from a pcap file or whatever). How hard would this be to do? |
L: TL0PICIDX present. When set to 1, the TL0PICIDX MUST be present
and specified as below, and the T bit MUST be set to 1.
Otherwise, TL0PICIDX MUST NOT be present.
Add Y bit and KEYIDX value to be obtain
Add Vp8 Key Frame validation
Get Width and Height and their scaling values from Vp8 Payload Header