Skip to content

Commit

Permalink
squash: move comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
damencho committed Oct 30, 2024
1 parent 57339b2 commit c979414
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public WhisperWebsocket getConnection(String roomId)
logger.info("Room " + roomId + " doesn't exist. Creating a new connection.");
final WhisperWebsocket socket = new WhisperWebsocket();

// connect socket in new thread to not block Smack threads
socket.connect();

pool.put(roomId, socket);
Expand All @@ -77,7 +76,6 @@ public WhisperWebsocket getConnection(String roomId)
*/
public void end(String roomId, String participantId)
{
// execute this in new thread to not block Smack
WhisperWebsocket wsConn = pool.getOrDefault(roomId, null);
if (wsConn == null)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ private void generateWebsocketUrl()
}

/**
* Connect to the websocket in a new thread.
* Connect to the websocket in a new thread so we do not block Smack.
*/
void connect()
{
Expand Down Expand Up @@ -403,7 +403,7 @@ private ByteBuffer buildPayload(String participantId, Participant participant, B
}

/**
* Disconnect a participant from the transcription service, executing that in a new thread.
* Disconnect a participant from the transcription service, executing that in a new thread so we do not block Smack.
* @param participantId the participant to disconnect.
* @param callback the callback to execute when the last participant is disconnected and session is closed.
*/
Expand Down

0 comments on commit c979414

Please sign in to comment.