feat(metadata): Keeps track of participants last used display name. #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Sep 17, 2024
| } | ||
| } | ||
| ); | ||
| APP.conference._room.room.addListener( | ||
| "xmpp.display_name_changed", | ||
| (jid, displayName) => { |
There was a problem hiding this comment.
Skip if display name is undefined or 0 length.
| (jid, displayName) => { | ||
| const identity = window._jibriParticipants.get(jid); | ||
| if (identity) { | ||
| identity.lastKnownDisplayName = displayName; |
There was a problem hiding this comment.
Pl set the display name property instead, so the JaaS webhook payload doesn't change since it takes it from the metadata file.
There was a problem hiding this comment.
So identity already has the display name that is coming from the jwt. Do you want to override that one and lost any values from it?
There was a problem hiding this comment.
I see, to overwrite name in user:
{
"user": {
"id": "123",
"name": "damencho",
"avatar": "https://"
},
"group": "456"
}
damencho
force-pushed
the
last-known-displayName
branch
from
5af9219
to
1948a96
Compare
saghul
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.