Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add prometheus metrics. #540

Merged
merged 7 commits into from
Mar 12, 2024
Merged

feat: Add prometheus metrics. #540

merged 7 commits into from
Mar 12, 2024

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Feb 28, 2024

  • ref: Move stats config to a separate file.
  • ref: Add an abstraction layer in front of statsd.
  • ref: Move statsd code under metrics, make private.
  • Add a prometheus interface at /metrics.
  • feat: Add "healthy" and "recording" metrics.
  • ref: Rename a function for clarity.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 6.97674% with 120 lines in your changes are missing coverage. Please review.

Project coverage is 46.34%. Comparing base (081b935) to head (d1a712c).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #540      +/-   ##
============================================
- Coverage     47.98%   46.34%   -1.64%     
- Complexity      174      175       +1     
============================================
  Files            73       75       +2     
  Lines          2130     2218      +88     
  Branches        205      198       -7     
============================================
+ Hits           1022     1028       +6     
- Misses         1040     1121      +81     
- Partials         68       69       +1     
Files Coverage Δ
...main/kotlin/org/jitsi/jibri/metrics/StatsConfig.kt 100.00% <100.00%> (ø)
...n/org/jitsi/jibri/metrics/JibriMetricsContainer.kt 0.00% <0.00%> (ø)
src/main/kotlin/org/jitsi/jibri/Main.kt 0.00% <0.00%> (ø)
...rc/main/kotlin/org/jitsi/jibri/api/xmpp/XmppApi.kt 48.92% <0.00%> (-0.28%) ⬇️
src/main/kotlin/org/jitsi/jibri/JibriManager.kt 5.94% <0.00%> (-2.64%) ⬇️
...rc/main/kotlin/org/jitsi/jibri/api/http/HttpApi.kt 33.87% <0.00%> (-5.02%) ⬇️
...ain/kotlin/org/jitsi/jibri/metrics/JibriMetrics.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081b935...d1a712c. Read the comment docs.

@bgrozev bgrozev merged commit 03d63f3 into master Mar 12, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants