Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: dont show curl progress in jibri log #520

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

emrahcom
Copy link
Contributor

@emrahcom emrahcom commented Oct 2, 2023

Run curl in silent mode to not add the curl progress info into jibri service logs,

such as

graceful_shutdown.sh[1053]:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
graceful_shutdown.sh[1053]:                                  Dload  Upload   Total   Spent    Left  Speed

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #520 (8d1f2bc) into master (aae8846) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #520   +/-   ##
=========================================
  Coverage     48.17%   48.17%           
  Complexity      174      174           
=========================================
  Files            72       72           
  Lines          2113     2113           
  Branches        201      201           
=========================================
  Hits           1018     1018           
  Misses         1027     1027           
  Partials         68       68           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae8846...8d1f2bc. Read the comment docs.

Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saghul saghul merged commit a8aacf1 into jitsi:master Oct 2, 2023
3 checks passed
@emrahcom emrahcom deleted the silent-curl branch October 2, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants