[Feature] 인기 있는 토론방 조회 API 및 최근 의견이 달린 토론방 API 구현 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jwooo
requested changes
Apr 24, 2024
Comment on lines
589
to
608
| Comment comment1 = Comment.builder() | ||
| .content("의견") | ||
| .user(user) | ||
| .talkRoom(talkRooms.get(3)) | ||
| .build(); | ||
| Comment comment2 = Comment.builder() | ||
| .content("의견") | ||
| .user(user) | ||
| .talkRoom(talkRooms.get(4)) | ||
| .build(); | ||
| Comment comment3 = Comment.builder() | ||
| .content("의견") | ||
| .user(user) | ||
| .talkRoom(talkRooms.get(5)) | ||
| .build(); | ||
| Comment comment4 = Comment.builder() | ||
| .content("의견 추가") | ||
| .user(user) | ||
| .talkRoom(talkRooms.get(5)) | ||
| .build(); |
There was a problem hiding this comment.
Comment 생성 메서드가 있는데 builder를 사용해서 객체를 생성하신 이유가 있나요?
There was a problem hiding this comment.
생성 메서드는 TalkRoom 0번 객체에만 만들어지기 때문에 여러 TalkRoom방에 Comment를 생성하기 위해 이렇게 작성했습니다.
There was a problem hiding this comment.
Comment comment1 = createComment(talkRooms.get(3), user);
Comment comment2 = createComment(talkRooms.get(4), user);
Comment comment3 = createComment(talkRooms.get(5), user);
Comment comment4 = createcomment(talkRooms.get(5), user);
commentRepository.saveAll(List.of(comment1, comment2, comment3, comment4));위와 같이 작성하면 되지 않을까요?
Comment on lines
146
to
153
| return talkRoom.createDateTime.desc(); | ||
| } else if (RECOMMEND.equals(orderType)) { | ||
| return talkRoomLike.count().desc(); | ||
| } else if (RECENT_COMMENT.equals(orderType)) { | ||
| return comment.createDateTime.max().desc(); | ||
| } | ||
| return OrderByNull.DEFAULT; | ||
| } |
There was a problem hiding this comment.
orderType이 RECENT_COMMENT일 때 max로 정렬 조건을 지정한 이유가 있을까요?
There was a problem hiding this comment.
max를 사용하지 않고 gropBy를 TalkRoom.id 로 하니 에러가 발생하더라구요. 그래서 gropBy를 없애고 comment.createDateTime.max().desc() 해결이 되어서 일단은 이렇게 작성해놨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #83
📝 작업 내용
💬 리뷰 요구 사항
Redis를 이용한 실시간 인기 있는 토론방 조회는 추후에 추가하는걸로 요구 사항이 변경되어 일단은 좋아요 높은 순으로 조회되는걸로 구현했습니다.