Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] TalkRoom Comment 수정, 삭제 API 구현 #39

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

AHNYUNKI
Copy link
Member

💡 연관된 이슈

close #38

📝 작업 내용

  • TalkRoom Comment 수정 API 구현
  • TalkRoom Comment 수정 API 테스트 코드 작성
  • TalkRoom Comment 삭제 API 구현
  • TalkRoom Comment 삭제 API 테스트 코드 작성

💬 리뷰 요구 사항

간단한 기능 구현이라 리뷰 요구 사항은 생략하도록 하겠습니다!

@AHNYUNKI AHNYUNKI added the ✨ Feature 기능 개발 label Mar 25, 2024
@AHNYUNKI AHNYUNKI requested review from pdohyung and jwooo March 25, 2024 10:23
@AHNYUNKI AHNYUNKI self-assigned this Mar 25, 2024
@AHNYUNKI AHNYUNKI linked an issue Mar 25, 2024 that may be closed by this pull request
4 tasks
Copy link
Member

@jwooo jwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

문제되는 부분 없어서 머지 허용하였습니다. 리뷰 남겼으니 답변 부탁드립니다!

@NoArgsConstructor
public class CommentEditRequest {

private String content;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 필드 제약 조건이 없는 이유가 있나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음 아직 PM님께서 제약 조건이 명확하게 정해지지 않았다고 하셔서 아직 설정을 안해놨습니다!

Copy link
Member

@pdohyung pdohyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 👍

@AHNYUNKI AHNYUNKI merged commit 3675e63 into develop Mar 25, 2024
1 check passed
@AHNYUNKI AHNYUNKI deleted the feature/38-talkroom-comment-edit-delete-api branch March 25, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] TalkRoom Comment 수정, 삭제 API 구현
3 participants