fix: KaraxとTwitterのJSライブラリが干渉しているのでJSライブラリを無効化 #204 (#205)

* fix: KaraxがエラーになっているためTwitterのJSライブラリのロードをやめる #204 * chore: Karaxのバージョンを上げる気はないのでバージョン固定 #204
jiro4989 · Apr 7, 2021 · 08ac6ee · 08ac6ee
1 parent a46961b
commit 08ac6ee
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/websh_front/public/index.html b/websh_front/public/index.html
@@ -6,7 +6,10 @@
 
   <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/bulma/0.8.0/css/bulma.min.css">
   <link rel="icon" href="/favicon.ico">
-  <script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>
+  <!--
+    #204 Karaxと干渉しているため
+    <script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>
+  -->
   <style>
   textarea {
     font-family: Consolas, 'Courier New', Courier, Monaco, monospace;

diff --git a/websh_front/src/index.nim b/websh_front/src/index.nim
@@ -225,8 +225,10 @@ proc createDom(): VNode =
                   button(class="button is-primary", onclick = sendShellButtonOnClick):
                     text "Run (Ctrl + Enter)"
                   a(href = &"""https://twitter.com/intent/tweet?hashtags={encodeUrl($hashTag, false)}&text={encodeUrl($inputShell, false)}&ref_src=twsrc%5Etfw""",
-                      class = "button twitter-share-button is-link",
-                      `data-show-count` = "false"):
+                      # #204 Karaxと干渉しているため
+                      # class = "button twitter-share-button is-link",
+                      # `data-show-count` = "false"):
+                      class = "button is-link"):
                     text "Tweet"
                   tdiv(class = "select"):
                     select:

diff --git a/websh_front/websh_front.nimble b/websh_front/websh_front.nimble
@@ -13,4 +13,4 @@ backend       = "js"
 # Dependencies
 
 requires "nim >= 1.4.0"
-requires "karax >= 1.1.3"
+requires "karax == 1.1.3"