feat: OpenJDK 16にアップグレード #49 #50

jiro4989 · 2021-10-30T01:27:22Z

close #49

やったこと

OpenJDKを14から16に変更した
JavFXを14から16に変更した
Gradleを6.3から7.2に変更した
- Gradle 6.3 がJDK16に対応していなかったため
GoogleJavaFormat用のGradlePluginを spotless を使うように変更した
- 積極的にメンテナンスされてないらしい
  - Is this project maintained? sherter/google-java-format-gradle-plugin#57
spotless で build.gradle のフォーマットをするように変更した
- 今回の対応と直接は関係ないけれど、 spotless がGroovyに対応していたのでついでで入れた
gradle taskのタスク間の依存関係を明示的に記述した
- 依存関係が明示されてないとタイミングによってタスクが失敗するようになる、というGradleの指摘でビルドが通らなくなったため
Gradle 8.0 で削除されるらしき warning を修正した
- 8b8c420 enabled を required に変更
- 4942370 getMainClass().set に変更
- 6a21768 jcenterメソッドを削除

おまけの改善

CIのファイル構成を変更した
- test と release のワークフローを分割した
PullReqeustのCIでartifactをアップロードするようにした
- MRのパイプラインでビルド済みartifactをダウンロードできるようになった
- これでいちいちWindows用のJARをビルドしなくて良くなった
CIでコードフォーマット済みかチェックするようにした
- コードフォーマットしてなかったらCIがコケる

jiro4989 · 2021-10-30T01:27:58Z

./gradlew build したらコケた

Welcome to Gradle 7.2!

Here are the highlights of this release:
 - Toolchain support for Scala
 - More cache hits when Java source files have platform-specific line endings
 - More resilient remote HTTP build cache behavior

For more details see https://docs.gradle.org/7.2/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* Where:
Build file '/home/jiro4989/src/github.com/jiro4989/TKoolFacetileMaker2/build.gradle' line: 52

* What went wrong:
A problem occurred evaluating root project 'TKoolFacetileMaker2'.
> Could not find method testCompile() for arguments [{group=org.junit.jupiter, name=junit-jupiter-api, version=5.6.2}] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 37s

jiro4989 · 2021-10-30T01:34:36Z

Gradle 7 になったことで testCompile が削除されたらしい。

testImplementationといったメソッドは公式ドキュメントのどこに書かれてるんだ？

https://docs.gradle.org/current/userguide/dependency_management_for_java_projects.html#sec:configurations_java_tutorial

jiro4989 · 2021-10-30T01:47:34Z

testImplementation に変更したらエラーが変わった

> Task :jar FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':jar'.
> Entry module-info.class is a duplicate but no duplicate handling strategy has been set. Please refer to https://docs.gradle.org/7.2/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 9s
4 actionable tasks: 4 executed

jiro4989 · 2021-10-30T01:50:20Z

エラーメッセージに従って --stacktrace オプションをつけて実行したらZIP周りのコピー処理でエラーになってるようにみえる

Caused by: org.gradle.api.InvalidUserCodeException: Entry module-info.class is a duplicate but no duplicate handling strategy has been set. Please refer to https://docs.gradle.org/7.2/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy for details.
        at org.gradle.api.internal.file.copy.DuplicateHandlingCopyActionDecorator.failWithIncorrectDuplicatesStrategySetup(DuplicateHandlingCopyActionDecorator.java:72)
        at org.gradle.api.internal.file.copy.DuplicateHandlingCopyActionDecorator.lambda$execute$0(DuplicateHandlingCopyActionDecorator.java:53)
        at org.gradle.api.internal.file.copy.CopyFileVisitorImpl.processFile(CopyFileVisitorImpl.java:68)
        at org.gradle.api.internal.file.copy.CopyFileVisitorImpl.visitFile(CopyFileVisitorImpl.java:52)
        at org.gradle.api.internal.file.collections.FilteredMinimalFileTree$2.visitFile(FilteredMinimalFileTree.java:113)
        at org.gradle.api.internal.file.archive.ZipFileTree.visit(ZipFileTree.java:107)
        ... 255 more

codecov · 2021-10-30T01:54:50Z

Codecov Report

Merging #50 (8b8c420) into master (ecc89c4) will increase coverage by 0.26%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #50      +/-   ##
============================================
+ Coverage     57.05%   57.32%   +0.26%     
  Complexity       93       93              
============================================
  Files            12       12              
  Lines           645      642       -3     
  Branches         37       37              
============================================
  Hits            368      368              
+ Misses          275      272       -3     
  Partials          2        2

Impacted Files	Coverage Δ
...rc/main/java/com/jiro4989/tkfm/MainController.java	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc89c4...8b8c420. Read the comment docs.

jiro4989 · 2021-10-30T01:56:09Z

正直Gradleの機能を全く理解していないので、Gradleちゃんと勉強して理解するまで寝かせる

jiro4989 · 2021-11-18T22:05:24Z

Execution failed for task ':jar'.
Entry module-info.class is a duplicate but no duplicate handling strategy has been set. Please refer to https://docs.gradle.org/7.2/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy for details.

タスク '：jar'の実行に失敗しました。
エントリmodule-info.classは重複していますが、重複処理戦略が設定されていません。詳細については、https：//docs.gradle.org/7.2/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy：duplicatesStrategyを参照してください。

jiro4989 · 2021-11-18T22:22:47Z

https://youtrack.jetbrains.com/issue/DOC-13130

jiro4989 · 2021-11-18T22:23:39Z

これでエラーが変わった

jiro4989 · 2021-11-18T22:26:35Z

$ ./gradlew build -x test

> Task :verifyGoogleJavaFormat FAILED
Execution optimizations have been disabled for task ':verifyGoogleJavaFormat' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/home/jiro4989/src/github.com/jiro4989/TKoolFacetileMaker2'. Reason: Task ':verifyGoogleJavaFormat' uses this output of task ':versionSet' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.

FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':verifyGoogleJavaFormat' (type 'VerifyGoogleJavaFormat').
  - In plugin 'com.github.sherter.google-java-format' type 'com.github.sherter.googlejavaformatgradleplugin.VerifyGoogleJavaFormat' property 'ignoreFailures' has redundant getters: 'getIgnoreFailures()' and 'isIgnoreFailures()'.

    Reason: Boolean property 'ignoreFailures' has both an `is` and a `get` getter.

    Possible solutions:
      1. Remove one of the getters.
      2. Annotate one of the getters with @Internal.

    Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#redundant_getters for more details about this problem.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.2/userguide/command_line_interface.html#sec:command_line_warnings

Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.

BUILD FAILED in 553ms
8 actionable tasks: 1 executed, 7 up-to-date

jiro4989 · 2021-11-18T22:29:01Z

https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency

jiro4989 · 2021-11-18T22:32:08Z

タスクの依存関係を設定していないので、潜在的なバグになる、ってことか

jiro4989 · 2021-11-18T22:32:18Z

この記事でも同じようなことが書いてある

https://irof.hateblo.jp/entry/2019/12/13/172428

jiro4989 · 2021-11-18T22:47:09Z

依存性を定義したらエラーが変わった

> Task :verifyGoogleJavaFormat FAILED

FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':verifyGoogleJavaFormat' (type 'VerifyGoogleJavaFormat').
  - In plugin 'com.github.sherter.google-java-format' type 'com.github.sherter.googlejavaformatgradleplugin.VerifyGoogleJavaFormat' property 'ignoreFailures' has redundant getters: 'getIgnoreFailures()' and 'isIgnoreFailures()'.

    Reason: Boolean property 'ignoreFailures' has both an `is` and a `get` getter.

    Possible solutions:
      1. Remove one of the getters.
      2. Annotate one of the getters with @Internal.

    Please refer to https://docs.gradle.org/7.2/userguide/validation_problems.html#redundant_getters for more details about this problem.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 691ms
2 actionable tasks: 2 executed

jiro4989 · 2021-11-18T23:02:43Z

積極的にメンテナンスされてないらしい。フォーマッタを別のに変えたほうがいいかもしれない

sherter/google-java-format-gradle-plugin#57

jiro4989 · 2021-11-18T23:05:58Z

コレ良さそう？

https://github.com/diffplug/spotless

https://progret.hatenadiary.com/entry/2019/12/09/165048

jiro4989 · 2021-11-23T02:28:23Z

切り替えて実行してみた

FAILURE: Build failed with an exception.

* Where:
Build file '/home/jiro4989/src/github.com/jiro4989/TKoolFacetileMaker2/build.gradle' line: 40

* What went wrong:
A problem occurred evaluating root project 'TKoolFacetileMaker2'.
> Failed to apply plugin 'com.diffplug.gradle.spotless'.
   > We have moved from 'com.diffplug.gradle.spotless'
                     to 'com.diffplug.spotless'
     To migrate:
     - Test your build with: id 'com.diffplug.gradle.spotless' version '4.5.1'
     - Fix any deprecation warnings (shouldn't be many / any)
     - Now you can use:      id 'com.diffplug.spotless' version '5.0.0'

     That's all you really need to know, but as always, there are more details in the changelog:
     https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md

     While you're at it, you might want to search for "target '**/".  We used
     to  recommend that in our README, but it's a lot slower than something
     more specific like "target 'src/**".  Also, if you haven't tried them yet,
     take a look at our IDE integration and 'ratchetFrom'.  We've found them
     to be useful, hope you do too.

     If you like the idea behind 'ratchetFrom', you should checkout spotless-changelog
     https://github.com/diffplug/spotless-changelog

jiro4989 · 2021-11-23T02:32:09Z

指摘を修正して再実行した

> Task :spotlessJava FAILED
Step 'google-java-format' found problem in 'src/main/java/com/jiro4989/tkfm/data/CropSize.java':
null
java.lang.reflect.InvocationTargetException
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:567)
        at com.diffplug.spotless.java.GoogleJavaFormatStep$State.lambda$createFormat$1(GoogleJavaFormatStep.java:176)
        at com.diffplug.spotless.FormatterFunc.apply(FormatterFunc.java:32)
        at com.diffplug.spotless.FormatterStepImpl$Standard.format(FormatterStepImpl.java:78)
        at com.diffplug.spotless.FormatterStep$Strict.format(FormatterStep.java:76)
        at com.diffplug.spotless.Formatter.compute(Formatter.java:230)
        at com.diffplug.spotless.PaddedCell.calculateDirtyState(PaddedCell.java:201)
        at com.diffplug.spotless.PaddedCell.calculateDirtyState(PaddedCell.java:188)
        at com.diffplug.gradle.spotless.SpotlessTaskImpl.processInputFile(SpotlessTaskImpl.java:88)
        at com.diffplug.gradle.spotless.SpotlessTaskImpl.performAction(SpotlessTaskImpl.java:74)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:567)
        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:104)
        at org.gradle.api.internal.project.taskfactory.IncrementalInputsTaskAction.doExecute(IncrementalInputsTaskAction.java:32)
        at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:51)
        at org.gradle.api.internal.project.taskfactory.AbstractIncrementalTaskAction.execute(AbstractIncrementalTaskAction.java:25)
        at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:29)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$2.run(ExecuteActionsTaskExecuter.java:502)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:75)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:68)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:153)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:68)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:56)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.lambda$run$1(DefaultBuildOperationExecutor.java:74)
        at org.gradle.internal.operations.UnmanagedBuildOperationWrapper.runWithUnmanagedSupport(UnmanagedBuildOperationWrapper.java:45)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:74)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:487)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:470)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.access$300(ExecuteActionsTaskExecuter.java:106)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$TaskExecution.executeWithPreviousOutputFiles(ExecuteActionsTaskExecuter.java:271)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$TaskExecution.execute(ExecuteActionsTaskExecuter.java:249)
        at org.gradle.internal.execution.steps.ExecuteStep.executeInternal(ExecuteStep.java:89)
        at org.gradle.internal.execution.steps.ExecuteStep.access$000(ExecuteStep.java:40)
        at org.gradle.internal.execution.steps.ExecuteStep$1.call(ExecuteStep.java:53)
        at org.gradle.internal.execution.steps.ExecuteStep$1.call(ExecuteStep.java:50)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:200)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:195)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:75)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:68)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:153)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:68)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:62)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.lambda$call$2(DefaultBuildOperationExecutor.java:79)
        at org.gradle.internal.operations.UnmanagedBuildOperationWrapper.callWithUnmanagedSupport(UnmanagedBuildOperationWrapper.java:54)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:79)
        at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:50)
        at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:40)
        at org.gradle.internal.execution.steps.RemovePreviousOutputsStep.execute(RemovePreviousOutputsStep.java:68)
        at org.gradle.internal.execution.steps.RemovePreviousOutputsStep.execute(RemovePreviousOutputsStep.java:38)
        at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:50)
        at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:36)
        at org.gradle.internal.execution.steps.CancelExecutionStep.execute(CancelExecutionStep.java:41)
        at org.gradle.internal.execution.steps.TimeoutStep.executeWithoutTimeout(TimeoutStep.java:74)
        at org.gradle.internal.execution.steps.TimeoutStep.execute(TimeoutStep.java:55)
        at org.gradle.internal.execution.steps.CreateOutputsStep.execute(CreateOutputsStep.java:51)
        at org.gradle.internal.execution.steps.CreateOutputsStep.execute(CreateOutputsStep.java:29)
        at org.gradle.internal.execution.steps.CaptureStateAfterExecutionStep.execute(CaptureStateAfterExecutionStep.java:58)
        at org.gradle.internal.execution.steps.CaptureStateAfterExecutionStep.execute(CaptureStateAfterExecutionStep.java:39)
        at org.gradle.internal.execution.steps.BroadcastChangingOutputsStep.execute(BroadcastChangingOutputsStep.java:60)
        at org.gradle.internal.execution.steps.BroadcastChangingOutputsStep.execute(BroadcastChangingOutputsStep.java:27)
        at org.gradle.internal.execution.steps.BuildCacheStep.executeWithoutCache(BuildCacheStep.java:180)
        at org.gradle.internal.execution.steps.BuildCacheStep.execute(BuildCacheStep.java:75)
        at org.gradle.internal.execution.steps.BuildCacheStep.execute(BuildCacheStep.java:46)
        at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:40)
        at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:29)
        at org.gradle.internal.execution.steps.RecordOutputsStep.execute(RecordOutputsStep.java:36)
        at org.gradle.internal.execution.steps.RecordOutputsStep.execute(RecordOutputsStep.java:22)
        at org.gradle.internal.execution.steps.SkipUpToDateStep.executeBecause(SkipUpToDateStep.java:105)
        at org.gradle.internal.execution.steps.SkipUpToDateStep.lambda$execute$0(SkipUpToDateStep.java:98)
        at java.base/java.util.Optional.map(Optional.java:260)
        at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:53)
        at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:37)
        at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:85)
        at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:42)
        at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:37)
        at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:27)
        at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:92)
        at org.gradle.internal.execution.steps.ResolveCachingStateStep.execute(ResolveCachingStateStep.java:50)
        at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:114)
        at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:57)
        at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:73)
        at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:47)
        at org.gradle.internal.execution.steps.SkipEmptyWorkStep.lambda$execute$2(SkipEmptyWorkStep.java:92)
        at java.base/java.util.Optional.orElseGet(Optional.java:364)
        at org.gradle.internal.execution.steps.SkipEmptyWorkStep.execute(SkipEmptyWorkStep.java:92)
        at org.gradle.internal.execution.steps.SkipEmptyWorkStep.execute(SkipEmptyWorkStep.java:33)
        at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsStartedStep.execute(MarkSnapshottingInputsStartedStep.java:38)
        at org.gradle.internal.execution.steps.LoadExecutionStateStep.execute(LoadExecutionStateStep.java:43)
        at org.gradle.internal.execution.steps.LoadExecutionStateStep.execute(LoadExecutionStateStep.java:31)
        at org.gradle.internal.execution.steps.AssignWorkspaceStep.lambda$execute$0(AssignWorkspaceStep.java:40)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$TaskExecution$2.withWorkspace(ExecuteActionsTaskExecuter.java:284)
        at org.gradle.internal.execution.steps.AssignWorkspaceStep.execute(AssignWorkspaceStep.java:40)
        at org.gradle.internal.execution.steps.AssignWorkspaceStep.execute(AssignWorkspaceStep.java:30)
        at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:37)
        at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:27)
        at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:44)
        at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:33)
        at org.gradle.internal.execution.impl.DefaultExecutionEngine$1.execute(DefaultExecutionEngine.java:76)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:185)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:174)
        at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:109)
        at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
        at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)
        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
        at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:200)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:195)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:75)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:68)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:153)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:68)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:62)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.lambda$call$2(DefaultBuildOperationExecutor.java:79)
        at org.gradle.internal.operations.UnmanagedBuildOperationWrapper.callWithUnmanagedSupport(UnmanagedBuildOperationWrapper.java:54)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:79)
        at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52)
        at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:74)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:402)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:389)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:382)
        at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:368)
        at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.lambda$run$0(DefaultPlanExecutor.java:127)
        at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:191)
        at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.executeNextNode(DefaultPlanExecutor.java:182)
        at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:124)
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
        at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
        at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:61)
        at java.base/java.lang.Thread.run(Thread.java:831)
Caused by: java.lang.IllegalAccessError: class com.google.googlejavaformat.java.JavaInput (in unnamed module @0x68e814ff) cannot access class com.sun.tools.javac.parser.Tokens$TokenKind (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.parser to unnamed module @0x68e814ff
        at com.google.googlejavaformat.java.JavaInput.buildToks(JavaInput.java:349)
        at com.google.googlejavaformat.java.JavaInput.buildToks(JavaInput.java:334)
        at com.google.googlejavaformat.java.JavaInput.<init>(JavaInput.java:276)
        at com.google.googlejavaformat.java.Formatter.getFormatReplacements(Formatter.java:280)
        at com.google.googlejavaformat.java.Formatter.formatSource(Formatter.java:267)
        at com.google.googlejavaformat.java.Formatter.formatSource(Formatter.java:233)
        ... 142 more

jiro4989 · 2021-11-23T02:33:32Z

これか？

https://zenn.dev/yuta_saito/articles/8b185a3786088b

jiro4989 · 2021-11-23T02:39:26Z

リポジトリ直下に gradle.properties を追加して

org.gradle.jvmargs=--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED

を追加したらエラーが直った

jiro4989 · 2021-11-23T04:27:28Z

ついでだったのでMRのCIでアーティファクトを作って、成果物をDLできるようにしたった

jiro4989 · 2021-11-23T07:07:22Z

よく見たら build.gradle のインデントがタブになっとるやないか...。
半角スペース2つに直す

jiro4989 · 2021-11-23T11:12:25Z

よくみたら警告メッセージが出てた

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.2/userguide/command_line_interface.html#sec:command_line_warnings

jiro4989 · 2021-11-23T11:13:28Z

> Configure project :
The RepositoryHandler.jcenter() method has been deprecated. This is scheduled to be removed in Gradle 8.0. JFrog announced JCenter's sunset in February 2021. Use mavenCentral() instead. Consult the upgrading guide for further information: https://docs.gradle.org/7.2/userguide/upgrading_version_6.html#jcenter_deprecation
        at build_1eght2xev4wbx2ii9ev1b421t$_run_closure1.doCall(/home/jiro4989/src/github.com/jiro4989/TKoolFacetileMaker2/build.gradle:45)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
The JavaApplication.setMainClassName(String) method has been deprecated. This is scheduled to be removed in Gradle 8.0. Use #getMainClass().set(...) instead. See https://docs.gradle.org/7.2/dsl/org.gradle.api.plugins.JavaApplication.html#org.gradle.api.plugins.JavaApplication:mainClass for more details.
        at build_1eght2xev4wbx2ii9ev1b421t$_run_closure3.doCall(/home/jiro4989/src/github.com/jiro4989/TKoolFacetileMaker2/build.gradle:73)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
The Report.enabled property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the required property instead. See https://docs.gradle.org/7.2/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:enabled for more details.
        at build_1eght2xev4wbx2ii9ev1b421t$_run_closure11$_closure23.doCall(/home/jiro4989/src/github.com/jiro4989/TKoolFacetileMaker2/build.gradle:124)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
The JavaExec.main property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the mainClass property instead. See https://docs.gradle.org/7.2/dsl/org.gradle.api.tasks.JavaExec.html#org.gradle.api.tasks.JavaExec:main for more details.

jiro4989 · 2021-11-23T11:25:49Z

> Configure project :
The JavaExec.main property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the mainClass property instead. See https://docs.gradle.org/7.2/dsl/org.gradle.api.tasks.JavaExec.html#org.gradle.api.tasks.JavaExec:main for more details.

これ残ってるけれど、僕の管理してるコード内に無い？

jiro4989 · 2021-11-23T11:27:07Z

JavaExecを使ってる箇所が無い。プラグインのなんかが使ってるんかね。

まぁいいや。分からないしスルーする

jiro4989 added 2 commits October 30, 2021 10:22

Javaのバージョンを16に変更 #49

0da663c

Gradleのバージョンを7系にあげた #49

07d3de2

github-actions bot added the feature label Oct 30, 2021

削除されたメソッドを testImplementation に変更 #49

ed3c2ac

duplicatesStrategy入れた

40982fe

依存性を定義

ed285ab

コードフォーマッタをspotlessに変更

0476bff

jiro4989 added 2 commits November 23, 2021 11:38

エラーになったのを修正

da1bcbb

コードフォーマットを適用した

090d1b7

groovyもフォーマットするようにしてフォーマットした

50a1720

jiro4989 added 2 commits November 23, 2021 13:12

fix

10f8164

fix

627877d

jiro4989 added 5 commits November 23, 2021 13:32

fix release ci

bfde4e1

update readme

dc28dbb

テストがコケてたの修正

3be1070

Typo

3a9530a

fix

b77411f

jiro4989 changed the title ~~OpenJDK 16にアップグレード #49~~ feat: OpenJDK 16にアップグレード #49 Nov 23, 2021

jiro4989 added 6 commits November 23, 2021 16:08

fix format style

a7c4659

fix

cc85dc5

fix format

1f141dd

add config

a25b455

code format

a178ebd

add style check

8fee95c

jiro4989 added 3 commits November 23, 2021 20:14

jcenterメソッドを削除

6a21768

getMainClass().set に変更

4942370

enabled を required に変更

8b8c420

jiro4989 merged commit a5c7c78 into master Nov 23, 2021

jiro4989 deleted the feature/java16 branch November 23, 2021 11:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: OpenJDK 16にアップグレード #49 #50

feat: OpenJDK 16にアップグレード #49 #50

jiro4989 commented Oct 30, 2021 •

edited

Loading

jiro4989 commented Oct 30, 2021

jiro4989 commented Oct 30, 2021 •

edited

Loading

jiro4989 commented Oct 30, 2021

jiro4989 commented Oct 30, 2021

codecov bot commented Oct 30, 2021 •

edited

Loading

jiro4989 commented Oct 30, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021 •

edited

Loading

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

feat: OpenJDK 16にアップグレード #49 #50

feat: OpenJDK 16にアップグレード #49 #50

Conversation

jiro4989 commented Oct 30, 2021 • edited Loading

やったこと

おまけの改善

jiro4989 commented Oct 30, 2021

jiro4989 commented Oct 30, 2021 • edited Loading

jiro4989 commented Oct 30, 2021

jiro4989 commented Oct 30, 2021

codecov bot commented Oct 30, 2021 • edited Loading

Codecov Report

jiro4989 commented Oct 30, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021 • edited Loading

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 18, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Nov 23, 2021

jiro4989 commented Oct 30, 2021 •

edited

Loading

jiro4989 commented Oct 30, 2021 •

edited

Loading

codecov bot commented Oct 30, 2021 •

edited

Loading

jiro4989 commented Nov 18, 2021 •

edited

Loading