Include docker login in Makefile using REGISTRY_USERNAME/PASSWORD

jingyuanliang · Jun 18, 2023 · f58c92e · f58c92e
1 parent 3767ea8
commit f58c92e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml
@@ -15,15 +15,8 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v3
 
-      - name: Log in to the Container registry
-        uses: docker/login-action@65b78e6e13532edd9afa3aa52ac7964289d1a9c1
-        with:
-          registry: ghcr.io
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
       - name: Build and push Docker image
-        run: make manifest-list
+        run: make login manifest-list
         env:
           REGISTRY: ghcr.io/${{ github.repository }}
           REGISTRY_USERNAME: ${{ github.actor }}

diff --git a/Makefile b/Makefile
@@ -307,6 +307,11 @@ $(CONTAINER_DOTFILES): .buildx-initialized
 	docker images -q $(REGISTRY)/$(BIN):$(TAG) > $@
 	echo
 
+login: # @HELP configures docker to be authenticated to the defined registry
+	docker login $(REGISTRY)      \
+	    -u "$(REGISTRY_USERNAME)" \
+	    -p "$(REGISTRY_PASSWORD)"
+
 push: # @HELP pushes the container for one platform ($OS/$ARCH) to the defined registry
 push: container
 	for bin in $(BINS); do                     \