Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution of Transfer of tokens don't work #279 #282

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Solution of Transfer of tokens don't work #279 #282

merged 7 commits into from
Jun 18, 2024

Conversation

fzeeshan
Copy link
Contributor

There is function call in UI that needs to be changed so the tokens can be transferred, it solves Transfer of tokens don't work #279

@fzeeshan
Copy link
Contributor Author

the changes have been tested by myself and few other users.

sheshnath-at-knoldus
sheshnath-at-knoldus reviewed May 15, 2024
View reviewed changes
Copy link

@sheshnath-at-knoldus sheshnath-at-knoldus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works after changing callable: 'transfer' to callable: 'transferAllowDeath',

NXHM
NXHM approved these changes May 26, 2024
View reviewed changes
Copy link

@NXHM NXHM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried in my computer and it works, it transfers tokens

@fzeeshan
Copy link
Contributor Author

My change works but they are not letting me merge it

fzeeshan

This comment was marked as duplicate.

Sign in to view

@fzeeshan
Copy link
Contributor Author

I'm new to this, so not sure if there is something I have to do on my side?

@NXHM
Copy link

NXHM commented Jun 11, 2024

i don´t know, i think we should wait to @sheshnath-at-knoldus review

@sacha-l
Copy link

sacha-l commented Jun 18, 2024

I believe @DrW3RK can help get this merged 👀

@DrW3RK DrW3RK merged commit b5141af into jimmychu0807:main Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheshnath-at-knoldus sheshnath-at-knoldus sheshnath-at-knoldus left review comments

@falcucci falcucci falcucci approved these changes

@NXHM NXHM NXHM approved these changes

@DrW3RK DrW3RK DrW3RK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fzeeshan @NXHM @sacha-l @falcucci @DrW3RK @sheshnath-at-knoldus