-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker for development and production environments #261
Open
ltfschoen
wants to merge
15
commits into
jimmychu0807:main
Choose a base branch
from
ltfschoen:luke/docker-minimal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltfschoen
changed the title
Docker for dev and prod env
Docker for development and production environments
Dec 15, 2022
ltfschoen
commented
Dec 24, 2022
ltfschoen
commented
Dec 24, 2022
ltfschoen
commented
Dec 24, 2022
ltfschoen
commented
Dec 24, 2022
ltfschoen
commented
Dec 25, 2022
ltfschoen
commented
Aug 27, 2023
&& yarn set version 3.1.1 \ | ||
&& yarn plugin import interactive-tools \ | ||
&& echo -e "nodeLinker: node-modules\n\n$(cat ${APP_PATH}/.yarnrc.yml)" > ${APP_PATH}/.yarnrc.yml \ | ||
&& yarn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be yarn install --production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WATCHPACK_POLLING=true
in the package.json file, which is required since we're using dependency react-scripts 5.config
object approach mentioned in the readme of this repo, however I can make a separate PR to include this functionality where it reads the contents of the .env file, then in an env.sh file the user may whitelist variables from the .env file that they want to add to an env-config.js file that may be injected as a script in the index.html file, however I was only able to get it to generate the env-config.js file in production, but I wasn't able to get it to work in development when runningyarn run start
, so I excluded it but I don't believe it is necessary anyway@hariaccubits