Skip to content

Commit

Permalink
fix: update concurrency and environment variables for pull_request_ta…
Browse files Browse the repository at this point in the history
…rget events in workflow files
  • Loading branch information
jill64 committed Jan 1, 2025
1 parent de73cde commit e8f99ff
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/deploy-test-buffered.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
pull_request_target:
branches: main

concurrency: deploy-test-buffered${{ (github.event_name == 'pull_request' && '-dev') || '' }}
concurrency: deploy-test-buffered${{ (github.event_name == 'pull_request_target' && '-dev') || '' }}

jobs:
buffered-deploy:
Expand Down Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Build
run: npm run build:all
env:
STAGE: ${{ github.event_name == 'pull_request' && 'dev' || 'prod' }}
STAGE: ${{ github.event_name == 'pull_request_target' && 'dev' || 'prod' }}
BUFFERED_RESPONSE: 'TRUE'
ADAPTER_ARCHITECTURE: ${{ matrix.architecture }}
ADAPTER_FQDN: ${{ format('buffered.{0}.adapter-aws.com', matrix.architecture) }}
Expand Down Expand Up @@ -72,5 +72,5 @@ jobs:
- name: Test
run: npx playwright test
env:
ADAPTER_FQDN: ${{ github.event_name == 'pull_request' && ((matrix.architecture == 'lambda-mono' && vars.BUFFERED_LAMBDA_MONO_PREVIEW_URL) || (matrix.architecture == 'lambda-s3' && vars.BUFFERED_LAMBDA_S3_PREVIEW_URL) || (matrix.architecture == 'edge-unbundled' && vars.BUFFERED_EDGE_UNBUNDLED_PREVIEW_URL)) || format('buffered.{0}.adapter-aws.com', matrix.architecture) }}
ADAPTER_FQDN: ${{ github.event_name == 'pull_request_target' && ((matrix.architecture == 'lambda-mono' && vars.BUFFERED_LAMBDA_MONO_PREVIEW_URL) || (matrix.architecture == 'lambda-s3' && vars.BUFFERED_LAMBDA_S3_PREVIEW_URL) || (matrix.architecture == 'edge-unbundled' && vars.BUFFERED_EDGE_UNBUNDLED_PREVIEW_URL)) || format('buffered.{0}.adapter-aws.com', matrix.architecture) }}
DEBUG_LOG: ${{ github.event_name }}
7 changes: 3 additions & 4 deletions .github/workflows/deploy-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
pull_request_target:
branches: main

concurrency: deploy-test${{ (github.event_name == 'pull_request' && '-dev') || '' }}
concurrency: deploy-test${{ (github.event_name == 'pull_request_target' && '-dev') || '' }}

jobs:
deploy:
Expand Down Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Build
run: npm run build:all
env:
STAGE: ${{ github.event_name == 'pull_request' && 'dev' || 'prod' }}
STAGE: ${{ github.event_name == 'pull_request_target' && 'dev' || 'prod' }}
ADAPTER_ARCHITECTURE: ${{ matrix.architecture }}
ADAPTER_FQDN: ${{ format('{0}.adapter-aws.com', matrix.architecture) }}
ADAPTER_CERTIFICATE_ARN: ${{ (matrix.architecture == 'lambda-mono' && secrets.LAMBDA_MONO_CERTIFICATE_ARN) || (matrix.architecture == 'lambda-s3' && secrets.LAMBDA_S3_CERTIFICATE_ARN) || (matrix.architecture == 'edge-bundled' && secrets.EDGE_BUNDLED_CERTIFICATE_ARN) || (matrix.architecture == 'edge-unbundled' && secrets.EDGE_UNBUNDLED_CERTIFICATE_ARN)}}
Expand Down Expand Up @@ -71,5 +71,4 @@ jobs:
- name: Test
run: npx playwright test
env:
ADAPTER_FQDN: ${{ github.event_name == 'pull_request' && ((matrix.architecture == 'lambda-mono' && vars.LAMBDA_MONO_PREVIEW_URL) || (matrix.architecture == 'lambda-s3' && vars.LAMBDA_S3_PREVIEW_URL) || (matrix.architecture == 'edge-bundled' && vars.EDGE_BUNDLED_PREVIEW_URL) || (matrix.architecture == 'edge-unbundled' && vars.EDGE_UNBUNDLED_PREVIEW_URL)) || format('{0}.adapter-aws.com', matrix.architecture) }}
DEBUG_LOG: ${{ github.event_name }}
ADAPTER_FQDN: ${{ github.event_name == 'pull_request_target' && ((matrix.architecture == 'lambda-mono' && vars.LAMBDA_MONO_PREVIEW_URL) || (matrix.architecture == 'lambda-s3' && vars.LAMBDA_S3_PREVIEW_URL) || (matrix.architecture == 'edge-bundled' && vars.EDGE_BUNDLED_PREVIEW_URL) || (matrix.architecture == 'edge-unbundled' && vars.EDGE_UNBUNDLED_PREVIEW_URL)) || format('{0}.adapter-aws.com', matrix.architecture) }}

0 comments on commit e8f99ff

Please sign in to comment.