Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Feature: Allows random endpoints to return multiple items #559

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Merge branch 'feature/multiplerandom' of https://github.com/jikan-me/…

39f18c2
Select commit
Loading
Failed to load commit list.
Open

✨Feature: Allows random endpoints to return multiple items #559

Merge branch 'feature/multiplerandom' of https://github.com/jikan-me/…
39f18c2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 1s

56.81% (-0.42%) compared to f9d6f87

View this Pull Request on Codecov

56.81% (-0.42%) compared to f9d6f87

Details

Codecov Report

Attention: Patch coverage is 50.90909% with 81 lines in your changes missing coverage. Please review.

Project coverage is 56.81%. Comparing base (f9d6f87) to head (39f18c2).

Files with missing lines Patch % Lines
app/Http/Controllers/V4DB/RandomController.php 0.00% 10 Missing ⚠️
app/Features/QueryRandomAnimeListHandler.php 22.22% 7 Missing ⚠️
app/Features/QueryRandomMangaListHandler.php 22.22% 7 Missing ⚠️
app/Features/QueryRandomCharacterHandler.php 0.00% 6 Missing ⚠️
app/Features/QueryRandomPersonHandler.php 0.00% 6 Missing ⚠️
app/Features/QueryRandomCharacterListHandler.php 28.57% 5 Missing ⚠️
app/Features/QueryRandomMangaHandler.php 0.00% 5 Missing ⚠️
app/Features/QueryRandomPersonListHandler.php 28.57% 5 Missing ⚠️
app/Features/QueryRandomUserListHandler.php 28.57% 5 Missing ⚠️
app/Features/QueryRandomAnimeHandler.php 0.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #559      +/-   ##
============================================
- Coverage     57.23%   56.81%   -0.42%     
- Complexity     1391     1420      +29     
============================================
  Files           340      344       +4     
  Lines          5670     5741      +71     
============================================
+ Hits           3245     3262      +17     
- Misses         2425     2479      +54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov