Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed an issue with casting query string params on /top/reviews endpoint #549

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

pushrbx
Copy link
Collaborator

@pushrbx pushrbx commented Jul 26, 2024

Fixes #548

@pushrbx pushrbx requested a review from a team as a code owner July 26, 2024 13:17
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.86%. Comparing base (9b9757c) to head (8bdcf97).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
app/Support/helpers.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #549      +/-   ##
============================================
+ Coverage     57.66%   57.86%   +0.19%     
  Complexity     1361     1361              
============================================
  Files           339      339              
  Lines          5270     5273       +3     
============================================
+ Hits           3039     3051      +12     
+ Misses         2231     2222       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@irfan-dahir irfan-dahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pushrbx Sorry, completely missed this one.

LGTM - Added a small fix as the TopReviewsTypeEnum was being passed into jikan as an object rather the type value which was throwing an exception.

$requestParams->get seems to be wrapping it back into an object - unsure why.

@pushrbx
Copy link
Collaborator Author

pushrbx commented Sep 28, 2024

I'm going to fix the test errors before I merge.

@pushrbx pushrbx merged commit 744bd69 into master Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [OFFICIAL] Generated Issue: CannotCastEnum
2 participants