Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑 Fixed issues around the season endpoint #515

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

pushrbx
Copy link
Collaborator

@pushrbx pushrbx commented Feb 13, 2024

I've introduced a regression in #482 where I used the wrong operators in mongodb and I forgot to add the case of "continuing" items from previous seasons.
Fixes #487
Fixes #513

@pushrbx pushrbx requested a review from a team as a code owner February 13, 2024 18:44
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (bb88011) 57.43% compared to head (8948dc1) 57.45%.

Files Patch % Lines
app/Repositories/DefaultAnimeRepository.php 76.92% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #515      +/-   ##
============================================
+ Coverage     57.43%   57.45%   +0.02%     
  Complexity     1352     1352              
============================================
  Files           339      339              
  Lines          5206     5209       +3     
============================================
+ Hits           2990     2993       +3     
  Misses         2216     2216              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@irfan-dahir irfan-dahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@irfan-dahir irfan-dahir merged commit a11a69b into master Mar 5, 2024
3 checks passed
@pushrbx pushrbx deleted the hotfix/aired-between-query branch May 26, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants