Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GithubReport.php #456

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ body:
- type: checkboxes
attributes:
label: Is there an existing issue for this?
description: It would greatly help us reducing duplicates and we would really appriacte if you could search the existing issues for the problem you are experiencing.
description: It would greatly help us reduce duplicates and we would really appreciate it if you could search the existing issues for the problem you are experiencing.
options:
- label: I have searched the existing issues
required: true
Expand All @@ -32,7 +32,7 @@ body:
id: repro_steps
attributes:
label: Steps To Reproduce
description: Steps to reproduce the behaviour. If the error came in a response from the REST API, please specify the url here.
description: Steps to reproduce the behaviour. If the error came in a response from the REST API, please specify the URL here.
placeholder: |
1. In this environment...
2. With this config...
Expand All @@ -46,16 +46,16 @@ body:
label: Environment
description: |
If you have used the public API, please just say "Used public API", and add your browser and its version.
If you are self-hosting, then write down your OS, the method of hosting (docker/container, kubernetes, or plain), and the version of jikan you are running.
If you are self-hosting, then write down your OS, the method of hosting (docker/container, Kubernetes, or plain), and the version of Jikan you are running.
examples:
- **OS**: Ubuntu 20.04
- **Browser**: Firefox 104.1
- **Android Runtime**: 7.6.3
placeholder: |
- OS:
- Browser:
- PHP Version on server side (if self-hosted):
- Is redis used (if self-hosted):
- PHP Version on the server side (if self-hosted):
- Is Redis used (if self-hosted):
- Search engine used (if self-hosted):
render: markdown
validations:
Expand All @@ -66,7 +66,7 @@ body:
label: Anything else?
description: |
Other information / Contextual information. Links? References? Anything that will give us more context about the issue you are encountering!
e.g. detailed explanation, stacktraces, related issues, screenshots, suggestions how to fix, links for us to have context, eg. stackoverflow, discord channel link, etc
e.g. detailed explanation, stack traces, related issues, screenshots, suggestions on how to fix, links for us to have context, eg. stackoverflow, discord channel link, etc

Tip: You can attach images or log files by clicking this area to highlight it and then dragging files in.
validations:
Expand Down
2 changes: 1 addition & 1 deletion app/Exceptions/GithubReport.php
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
"Jikan Parser Version**: ```{$this->jikanVersion}```\nPHP: ```{$this->phpVersion}```\nIs redis used: ```{$this->redisRunning}```"
);
$reproSteps = urlencode(
"Http Request: `{$this->requestMethod} {$this->requestUri}"
"Http Request: `{$this->requestMethod} {$this->requestUri}`"

Check warning on line 125 in app/Exceptions/GithubReport.php

View check run for this annotation

Codecov / codecov/patch

app/Exceptions/GithubReport.php#L125

Added line #L125 was not covered by tests
);

return "https://github.com/{$this->repo}/issues/new?template=bug.yml&title={$title}&system_env={$env}&repro_steps={$reproSteps}&expected_behavior={$expectedBehavior}&current_behavior={$currentBehavior}";
Expand Down