Allow not setting a string descriptor #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiegec
reviewed
Oct 24, 2024
| pub fn set_configuration_name(&mut self, name: &str) -> Option<String> { | ||
| self.string_pool | ||
| .insert(self.string_configuration, name.to_string()) | ||
| pub fn set_configuration_name(&mut self, name: Option<&str>) -> Option<String> { |
There was a problem hiding this comment.
I think it is unclear, maybe we should use two apis for set & clear?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most devices don't actually set interface descriptors or manufacturer/product name/serial numbers - instead leaving all those strings to 0, likely to save up on space.
I want to test drivers to make sure they react properly to either missing or presence of string descriptor, so I need to have control over whether a string is there or not.
With this MR, all strings start by being unset, and the various functions to set a string now take an
Option<&str>, with None meaning 0/no string descriptor.This is an API-breaking change.