Switch to Java's UncheckedIOException. #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing because we currently have <excludes>
<exclude>@java.lang.Deprecated</exclude>
</excludes>configured in japicmp. This allows the previously deprecated methods (between 1.16.1 and removed in 1.16.2) to not blow up. But I can't see a way to configure japicmp to allow this to be marked deprecated while that exclude is on -- it makes the class invisible and therefore looks like a removal. So I think we need to pick it up after the next release. Also I think we should change the signature to public class UncheckedIOException extends java.io.UncheckedIOException (and throw the extended not base version) for a release. That way if anyone is explicitly catching this exception, the current code will still work and they have an opportunity to migrate. |
The internal throws will continue to throw the internal UncheckedIOException shim, which now extends the java.io version. But the declared / visible throws are java.io. So in the next release we can mark Deprecated, and then remove subsequently.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.