Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating a base sqlite URL with sqlite: instead of sqlite:// #5

Closed
wants to merge 1 commit into from

Conversation

Grinnz
Copy link
Contributor

@Grinnz Grinnz commented Sep 20, 2015

The URL "sqlite://" causes URI::db to turn a relative "dbname" into an absolute path, this may be a bug in URI::db but it is avoided by starting with the URL "sqlite:". "sqlite:foo.db" is unambiguous but "sqlite:///foo.db" is parsed as an absolute path, while "sqlite://localhost/foo.db" is parsed as a relative path. Passing an absolute "dbname" results in the same URL whether you start with "sqlite:" or "sqlite://".

@jhthorsen
Copy link
Owner

I don't understand what this fix, since the module never care about the input database name.

@Grinnz
Copy link
Contributor Author

Grinnz commented Sep 21, 2015

The module doesn't care, but it uses it in a test and it would be better to recommend the more portable way in docs.

@Grinnz
Copy link
Contributor Author

Grinnz commented Sep 21, 2015

I opened libwww-perl/URI-db#8 about the underlying issue that comes up when starting with sqlite://.

@jhthorsen
Copy link
Owner

Thanks for clearing up 👍

@jhthorsen jhthorsen closed this in 44fc921 Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants