Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added test for dio #223

Merged
merged 15 commits into from
Jul 7, 2024
Merged

feat: added test for dio #223

merged 15 commits into from
Jul 7, 2024

Conversation

jhomlala
Copy link
Owner

@jhomlala jhomlala commented Jul 5, 2024 •
edited
Loading

Changelog:

  • Added tests for Dio adapter.
  • Added test utils package (not publishable).
  • Fixed issue with error calls count in stats page.

@jhomlala jhomlala requested a review from techouse July 7, 2024 12:10
@jhomlala
Copy link
Owner Author

jhomlala commented Jul 7, 2024

@techouse I think you can revisit it again. It's still in draft, but It's almost there.

@jhomlala jhomlala marked this pull request as ready for review July 7, 2024 16:17
techouse
techouse approved these changes Jul 7, 2024
View reviewed changes
Copy link
Collaborator

@techouse techouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhomlala jhomlala merged commit da907e7 into master Jul 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techouse techouse techouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhomlala @techouse