Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Codebase refactor part 2 & bug fixes #221

Merged
merged 20 commits into from
Jul 7, 2024
Merged

refactor: Codebase refactor part 2 & bug fixes #221

merged 20 commits into from
Jul 7, 2024

Conversation

jhomlala
Copy link
Owner

@jhomlala jhomlala commented Jul 3, 2024 •
edited
Loading

Changelog:

  • [BREAKING_CHANGE] Removed maxCallsCount. To change call count, use storage constructor parameter
    with call count.
  • [BREAKING_CHANGE] Replaced configuration parameter of Alice with AliceConfiguration.
  • Fixed issue with invalid count of calls in notification.
  • Added payload to notification.
  • General refactor of code base.
  • Updated documentation.

@jhomlala jhomlala changed the title Refactor/general overhaul 2 refactor: General overhaul Jul 3, 2024
@jhomlala jhomlala marked this pull request as ready for review July 4, 2024 18:55
@jhomlala jhomlala requested a review from techouse July 4, 2024 18:56
@jhomlala
Copy link
Owner Author

jhomlala commented Jul 4, 2024

@techouse Can you check it please?

@techouse
Copy link
Collaborator

techouse commented Jul 5, 2024

Will do over the weekend mate :)

@jhomlala jhomlala changed the title refactor: General overhaul refactor: Codebase refactor part 2 & bug fixes Jul 5, 2024
techouse
techouse requested changes Jul 5, 2024
View reviewed changes
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/install.md Show resolved Hide resolved
examples/alice_chopper/lib/main.dart Outdated Show resolved Hide resolved
packages/alice/lib/core/alice_logger.dart Outdated Show resolved Hide resolved
packages/alice/lib/core/alice_logger.dart Outdated Show resolved Hide resolved
packages/alice/lib/core/alice_memory_storage.dart Outdated Show resolved Hide resolved
packages/alice/lib/model/alice_configuration.dart Outdated Show resolved Hide resolved
packages/alice/lib/ui/calls_list/widget/alice_log_list_widget.dart Show resolved Hide resolved
@techouse
Copy link
Collaborator

techouse commented Jul 5, 2024

Left some comments.

@jhomlala jhomlala requested a review from techouse July 7, 2024 07:31
techouse
techouse requested changes Jul 7, 2024
View reviewed changes
packages/alice/lib/model/alice_configuration.dart Outdated Show resolved Hide resolved
packages/alice/lib/core/alice_logger.dart Outdated Show resolved Hide resolved
@techouse
Copy link
Collaborator

techouse commented Jul 7, 2024 •
edited
Loading

Added a few more nitpicky comments.

@jhomlala jhomlala requested a review from techouse July 7, 2024 10:21
@jhomlala
Copy link
Owner Author

jhomlala commented Jul 7, 2024

All should be resolved 👍

@jhomlala jhomlala merged commit cb213a7 into master Jul 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techouse techouse techouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhomlala @techouse