chore: refactor CI #220
Merged
chore: refactor CI #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf85902.
|
Why not using |
|
The only time you should do that is when you use a reusable workflow, e.g. jobs:
test:
uses: ./.github/workflows/test.yml
secrets: inheritUsing a shell script like this is dirty because it does nothing special. I'd understand if it were some bash function that's hard to read in YAML or something similar to what
Kinda. It's explicit. |
|
Okay, now it makes sense 👍 |
jhomlala
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facelift the CI a bit.
I'm not sure this needssubosito/flutter-actionto be honest. It can probably work withdart-lang/setup-dartMelos needs Flutter 🤪