Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up examples/alice_http_client #218

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Jul 3, 2024

  • drop web example
  • drop windows example
  • drop linux example
  • drop macos example

This PR re-applies the changes made in 29a71db as a PR

@jhomlala
Copy link
Owner

jhomlala commented Jul 3, 2024

I'm back with question:

Why we're dropping support for desktop? The goal is to have support for all platforms, except web where it's easy to use build in inspector.

@techouse
Copy link
Collaborator Author

techouse commented Jul 3, 2024

Does it make much sense? I think it's overkill as an example.

@jhomlala
Copy link
Owner

jhomlala commented Jul 3, 2024

Sure, but let's imagine scenario where you're manual tester and you don't have an access to the code and want to share information about calls from some desktop application which you're testing.

@techouse
Copy link
Collaborator Author

techouse commented Jul 3, 2024

Besides, it probably doesn't work because
image
So what's the point?

@jhomlala
Copy link
Owner

jhomlala commented Jul 3, 2024

Yeah I know, it's because of the dependencies that we're using - pub.dev analyzer (pana) is really restrictive. Anyway at this moment we know that Alice works fine on mobile, but ultimate goal is to support other platforms too. Web doesn't make any sense - there are build in inspector tools in web browsers. But for desktop, we could have support without doing huge changes.
At this moment it's okay to remove unsupported platforms from examples, but at the end we will revert it in some point in the future.

@techouse techouse merged commit 4137340 into master Jul 3, 2024
2 checks passed
@techouse techouse deleted the chore/examples/clean-up-alice_http_client branch July 3, 2024 08:33
@techouse
Copy link
Collaborator Author

techouse commented Jul 3, 2024

Ok, if that's the ultimate goal, then we add them back in the examples in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants