Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Overall code refactor and unit tests introduction #208

Merged
merged 25 commits into from
Jul 3, 2024
Merged

feat: Overall code refactor and unit tests introduction #208

merged 25 commits into from
Jul 3, 2024

Conversation

jhomlala
Copy link
Owner

@jhomlala jhomlala commented Jun 28, 2024 •
edited
Loading

Changelog:

  • Overall code refactor and clean up
  • Added unit tests
  • Updated CI/CD with test task

@jhomlala jhomlala changed the title feat: added unit tests, removed unused methods feat: unit tests, clean up of unused code Jun 29, 2024
@jhomlala
fix: fixed issues
9d74d6e
@jhomlala
fix: fixed issues
64d4de1
@jhomlala
Merge branch 'master' of https://github.com/jhomlala/alice into feat/…
dcb467a 
…unit_tests

# Conflicts:
#	packages/alice/lib/core/alice_core.dart
#	packages/alice/lib/core/alice_storage.dart
#	packages/alice_objectbox/lib/alice_objectbox.dart
#	packages/alice_objectbox/lib/model/cached_alice_http_call.dart
#	packages/alice_objectbox/lib/model/cached_alice_http_error.dart
#	packages/alice_objectbox/lib/model/cached_alice_http_request.dart
#	packages/alice_objectbox/lib/model/cached_alice_http_response.dart
@jhomlala
fix: fixed issues
25e13f3
@jhomlala
fix: changed headers definition
0de490f
@jhomlala
feat: added tests
c005278
techouse
techouse requested changes Jul 2, 2024
View reviewed changes
packages/alice_objectbox/lib/model/cached_alice_http_call.dart Outdated Show resolved Hide resolved
packages/alice_objectbox/lib/model/cached_alice_http_call.dart Show resolved Hide resolved
packages/alice_objectbox/lib/model/cached_alice_http_error.dart Show resolved Hide resolved
packages/alice_objectbox/lib/model/cached_alice_http_error.dart Show resolved Hide resolved
packages/alice_objectbox/lib/model/cached_alice_http_request.dart Show resolved Hide resolved
packages/alice_objectbox/lib/model/cached_alice_http_request.dart Show resolved Hide resolved
packages/alice_objectbox/lib/model/cached_alice_http_response.dart Show resolved Hide resolved
packages/alice_objectbox/lib/model/cached_alice_http_response.dart Show resolved Hide resolved
packages/alice_objectbox/lib/model/cached_alice_http_response.dart Show resolved Hide resolved
@techouse
Copy link
Collaborator

techouse commented Jul 2, 2024

I left some more comments, mostly about some overridden equitability methods that are verbatim copies of their super methods.

@jhomlala jhomlala changed the title feat: unit tests, clean up of unused code feat: Overhaul code refactor and unit tests introduction Jul 3, 2024
@jhomlala jhomlala changed the title feat: Overhaul code refactor and unit tests introduction feat: Overhaul of code and unit tests introduction Jul 3, 2024
@jhomlala
refactor: general refactor
1adc9dd
@jhomlala
Merge branch 'master' of https://github.com/jhomlala/alice into feat/…
cf3a79d 
…unit_tests

# Conflicts:
#	packages/alice_dio/.flutter-plugins
#	packages/alice_dio/.flutter-plugins-dependencies
@jhomlala jhomlala changed the title feat: Overhaul of code and unit tests introduction feat: Overall code refactor and unit tests introduction Jul 3, 2024
@jhomlala jhomlala marked this pull request as ready for review July 3, 2024 08:38
@jhomlala jhomlala requested a review from techouse July 3, 2024 08:38
@jhomlala
Copy link
Owner Author

jhomlala commented Jul 3, 2024 •
edited
Loading

@techouse Could you review it again? I think I will rework it once again in the future, but don't want to make it too big.

techouse
techouse requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@techouse techouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

packages/alice/lib/helper/operating_system.dart Outdated Show resolved Hide resolved
packages/alice/test/mocked_data.dart Outdated Show resolved Hide resolved
@jhomlala jhomlala requested a review from techouse July 3, 2024 10:32
techouse
techouse approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@techouse techouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhomlala jhomlala merged commit 52b89d0 into master Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techouse techouse techouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhomlala @techouse