Feat/translation #206
Merged
Feat/translation #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@techouse Could you check it please? |
|
Looks good at first glance, I just wonder why you didn't opt for something like https://pub.dev/packages/easy_localization and JSON files. |
|
I'm trying to not using deps for problems which I can easily handle. Less deps = more maintainable code. Also |
|
LGTM then :) |
…translation # Conflicts: # packages/alice/lib/core/alice_core.dart # packages/alice/lib/helper/alice_save_helper.dart
techouse
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
context.i18nextension to access translations