feat: Added require_trailing_commas lint (#224)

* feat: updated lint, dart fix * feat: updated metadata, dart format * fix: fixed PR comment
jhomlala · Jul 8, 2024 · 1a1ec27 · 1a1ec27
1 parent da907e7
commit 1a1ec27
Show file tree

Hide file tree

Showing 63 changed files with 905 additions and 676 deletions.
diff --git a/examples/alice/analysis_options.yaml b/examples/alice/analysis_options.yaml
@@ -9,4 +9,4 @@ include: package:flutter_lints/flutter.yaml
 
 linter:
   rules:
-    #library_annotations: false
+    - require_trailing_commas
diff --git a/examples/alice/lib/main.dart b/examples/alice/lib/main.dart
@@ -50,7 +50,7 @@ class _MyAppState extends State<MyApp> {
                 child: const Text(
                   'Run HTTP Inspector',
                 ),
-              )
+              ),
             ],
           ),
         ),

diff --git a/examples/alice_chopper/analysis_options.yaml b/examples/alice_chopper/analysis_options.yaml
@@ -10,4 +10,4 @@ include: package:flutter_lints/flutter.yaml
 
 linter:
   rules:
-    #library_annotations: false
+    - require_trailing_commas
diff --git a/examples/alice_chopper/lib/main.dart b/examples/alice_chopper/lib/main.dart
@@ -476,7 +476,7 @@ class _MyAppState extends State<MyApp> {
               ElevatedButton(
                 onPressed: _runHttpInspector,
                 child: const Text('Run HTTP Inspector'),
-              )
+              ),
             ],
           ),
         ),

diff --git a/examples/alice_dio/analysis_options.yaml b/examples/alice_dio/analysis_options.yaml
@@ -9,4 +9,4 @@ include: package:flutter_lints/flutter.yaml
 
 linter:
   rules:
-    #library_annotations: false
+    - require_trailing_commas
diff --git a/examples/alice_dio/lib/main.dart b/examples/alice_dio/lib/main.dart
@@ -62,7 +62,7 @@ class _MyAppState extends State<MyApp> {
                 child: const Text(
                   'Run HTTP Inspector',
                 ),
-              )
+              ),
             ],
           ),
         ),
@@ -74,7 +74,7 @@ class _MyAppState extends State<MyApp> {
     final Map<String, dynamic> body = {
       'title': 'foo',
       'body': 'bar',
-      'userId': '1'
+      'userId': '1',
     };
     _dio.get<void>(
       'https://httpbin.org/redirect-to?url=https%3A%2F%2Fhttpbin.org',

diff --git a/examples/alice_http/analysis_options.yaml b/examples/alice_http/analysis_options.yaml
@@ -9,4 +9,4 @@ include: package:flutter_lints/flutter.yaml
 
 linter:
   rules:
-    #library_annotations: false
+    - require_trailing_commas
diff --git a/examples/alice_http/lib/main.dart b/examples/alice_http/lib/main.dart
@@ -58,7 +58,7 @@ class _MyAppState extends State<MyApp> {
                 child: const Text(
                   'Run HTTP Inspector',
                 ),
-              )
+              ),
             ],
           ),
         ),
@@ -70,7 +70,7 @@ class _MyAppState extends State<MyApp> {
     final Map<String, String> body = {
       'title': 'foo',
       'body': 'bar',
-      'userId': '1'
+      'userId': '1',
     };
 
     http

diff --git a/examples/alice_http_client/analysis_options.yaml b/examples/alice_http_client/analysis_options.yaml
@@ -9,4 +9,4 @@ include: package:flutter_lints/flutter.yaml
 
 linter:
   rules:
-    #library_annotations: false
+    - require_trailing_commas
diff --git a/examples/alice_http_client/lib/main.dart b/examples/alice_http_client/lib/main.dart
@@ -41,7 +41,9 @@ class _MyAppState extends State<MyApp> {
             children: [
               const SizedBox(height: 8),
               const Text(
-                  'Welcome to example of Alice Http Inspector. Click buttons below to generate sample data.'),
+                'Welcome to example of Alice Http Inspector.'
+                ' Click buttons below to generate sample data.',
+              ),
               ElevatedButton(
                 onPressed: _runHttpHttpClientRequests,
                 child: const Text(
@@ -50,14 +52,16 @@ class _MyAppState extends State<MyApp> {
               ),
               const SizedBox(height: 8),
               const Text(
-                  'After clicking on buttons above, you should receive notification.'
-                  ' Click on it to show inspector. You can also shake your device or click button below.'),
+                'After clicking on buttons above, you should receive'
+                ' notification. Click on it to show inspector. You can '
+                'also shake your device or click button below.',
+              ),
               ElevatedButton(
                 onPressed: _runHttpInspector,
                 child: const Text(
                   'Run HTTP Inspector',
                 ),
-              )
+              ),
             ],
           ),
         ),
@@ -69,7 +73,7 @@ class _MyAppState extends State<MyApp> {
     final Map<String, dynamic> body = {
       'title': 'foo',
       'body': 'bar',
-      'userId': '1'
+      'userId': '1',
     };
 
     _httpClient

diff --git a/examples/alice_objectbox/analysis_options.yaml b/examples/alice_objectbox/analysis_options.yaml
@@ -7,4 +7,4 @@ include: package:flutter_lints/flutter.yaml
 
 linter:
   rules:
-    #library_annotations: false
+    - require_trailing_commas
diff --git a/examples/alice_objectbox/lib/main.dart b/examples/alice_objectbox/lib/main.dart
@@ -42,7 +42,7 @@ class _MyAppState extends State<MyApp> {
     ),
   );
   late final Alice _alice = Alice(
-    configuration: configuration
+    configuration: configuration,
   )..addAdapter(_aliceHttpAdapter);
 
   @override
@@ -82,7 +82,7 @@ class _MyAppState extends State<MyApp> {
                 child: const Text(
                   'Run HTTP Inspector',
                 ),
-              )
+              ),
             ],
           ),
         ),
@@ -94,7 +94,7 @@ class _MyAppState extends State<MyApp> {
     final Map<String, String> body = {
       'title': 'foo',
       'body': 'bar',
-      'userId': '1'
+      'userId': '1',
     };
 
     http

diff --git a/packages/alice/CHANGELOG.md b/packages/alice/CHANGELOG.md
@@ -1,5 +1,7 @@
 # 1.0.0-dev.11
 * Fixed issue with invalid count of error calls in stats page.
+* Added lint for trailing commas.
+* General refactor of code base.
 
 # 1.0.0-dev.10
 

diff --git a/packages/alice/analysis_options.yaml b/packages/alice/analysis_options.yaml
@@ -7,4 +7,4 @@ include: package:flutter_lints/flutter.yaml
 
 linter:
   rules:
-    #library_annotations: false
+    - require_trailing_commas
diff --git a/packages/alice/lib/core/alice_core.dart b/packages/alice/lib/core/alice_core.dart
@@ -129,7 +129,9 @@ class AliceCore {
   /// Save all calls to file.
   Future<AliceExportResult> saveCallsToFile(BuildContext context) =>
       AliceExportHelper.saveCallsToFile(
-          context, _configuration.aliceStorage.getCalls());
+        context,
+        _configuration.aliceStorage.getCalls(),
+      );
 
   /// Adds new log to Alice logger.
   void addLog(AliceLog log) => _configuration.aliceLogger.add(log);

diff --git a/packages/alice/lib/core/alice_memory_storage.dart b/packages/alice/lib/core/alice_memory_storage.dart
@@ -45,15 +45,19 @@ class AliceMemoryStorage implements AliceStorage {
           )
           .length,
       redirects: calls
-          .where((AliceHttpCall call) =>
-              (call.response?.status.gte(300) ?? false) &&
-              (call.response?.status.lt(400) ?? false))
+          .where(
+            (AliceHttpCall call) =>
+                (call.response?.status.gte(300) ?? false) &&
+                (call.response?.status.lt(400) ?? false),
+          )
           .length,
       errors: calls
-          .where((AliceHttpCall call) =>
-              ((call.response?.status.gte(400) ?? false) &&
-                  (call.response?.status.lt(600) ?? false)) ||
-              const [-1, 0].contains(call.response?.status))
+          .where(
+            (AliceHttpCall call) =>
+                ((call.response?.status.gte(400) ?? false) &&
+                    (call.response?.status.lt(600) ?? false)) ||
+                const [-1, 0].contains(call.response?.status),
+          )
           .length,
       loading: calls.where((AliceHttpCall call) => call.loading).length,
     );