Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support azure container apps #448

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

fangjian0423
Copy link

@fangjian0423 fangjian0423 commented Aug 30, 2024

Some updates:

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2024

CLA assistant check
All committers have signed the CLA.

@fangjian0423
Copy link
Author

hi team, could you tell me how to fix the prettier check issue?

I try to run npm run prettier:format, but it does not take effect.

@hangwan97
Copy link

prettier

Lets try to format that locally (reformat everything) then commit to the github.

@jdubois
Copy link
Member

jdubois commented Sep 10, 2024

Can you run prettier --check "{,src/**/}*.{md,json,yaml,yml,java,ts,js,css,scss}" on your machine so you can see what the issue is?

@fangjian0423
Copy link
Author

fangjian0423 commented Sep 18, 2024

Can you run prettier --check "{,src/**/}*.{md,json,yaml,yml,java,ts,js,css,scss}" on your machine so you can see what the issue is?

hey @jdubois , after upgrade the prettier and prettier-plugin-java to the correct version (1.19.1 for prettier and 0.8.3 for prettier-plugin-java). The command you mentioned return:

> prettier --check "{,src/**/}*.{md,json,yaml,yml,java,ts,js,css,scss}"
Checking formatting...
All matched files use Prettier code style!

could you help to approve the workflow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants