Improve buttons #4195
Merged
Improve buttons #4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Gnuk
commented
Oct 31, 2022
Gnuk
commented
- Related to UX/UI: improve the CSS #2894
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4195 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2277 2277
===========================================
Files 597 597
Lines 9753 9753
Branches 189 189
===========================================
Hits 9753 9753 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pascalgrimaud
added
area: enhancement 🔧
generator: internal
and removed
area: triage
labels
Gnuk
force-pushed
the
improve-buttons
branch
2 times, most recently
from
b6ae43d
to
1923a01
Compare
Gnuk
force-pushed
the
improve-buttons
branch
from
1923a01
to
5e1571d
Compare
|
I worked with @ascelineboullen for some colors, fonts and button style. |
DamnClin
reviewed
Dec 17, 2022
| color: $jhlite-button-color-text; | ||
| font-family: $jhlite-global-font-primary-family; | ||
| font-size: $jhlite-button-font-size; | ||
| font-weight: bold; |
There was a problem hiding this comment.
Gave it a try and I think it's really better in default weight cc @Gnuk @ascelineboullen what do you think?
DamnClin
reviewed
Dec 17, 2022
| $jhlite-global-color-text-light: $jhlite-global-color-light !default; | ||
| $jhlite-global-color-link-light: $jhlite-global-color-light !default; | ||
| $jhlite-global-color-link-light-hover: $jhlite-global-color-primary !default; | ||
| $jhlite-global-color-fill-secondary: $jhlite-color-neutral-900 !default; // @deprecated |
There was a problem hiding this comment.
Created #4763 as follow up
|
Merging like that, comments can be taken in dedicated PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.