Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add style from tikui #3042

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Add style from tikui #3042

merged 1 commit into from
Aug 29, 2022

Conversation

Gnuk
Copy link
Collaborator

@Gnuk Gnuk commented Aug 12, 2022 •
edited
Loading

Related to #2894

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 12, 2022 •
edited
Loading

Codecov Report

Merging #3042 (1619184) into main (3c816aa) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##                main     #3042   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1972      1972           
===========================================
  Files            518       518           
  Lines           8513      8513           
  Branches         175       175           
===========================================
  Hits            8513      8513

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Gnuk Gnuk force-pushed the style-from-tikui branch 6 times, most recently from ada0ca7 to 8067cb0 Compare August 19, 2022 14:24
@Gnuk Gnuk force-pushed the style-from-tikui branch 2 times, most recently from 4c35e9f to 75fdd94 Compare August 22, 2022 07:56
pascalgrimaud
pascalgrimaud requested changes Aug 29, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
.github/actions/setup/action.yml Outdated Show resolved Hide resolved
@Gnuk Gnuk marked this pull request as ready for review August 29, 2022 11:43
@hdurix
Copy link
Member

hdurix commented Aug 29, 2022

I've got an error when I'm trying to build the app, for instance with ./mvnw:

[INFO] Building on /home/hippolyte/workspace/jhipster/jhipster-lite/target/classes/public/style directory.
[INFO] [0] node:internal/modules/cjs/loader:959
[INFO] [0]   throw err;
[INFO] [0]   ^
[INFO] [0] 
[INFO] [0] Error: Cannot find module '/home/hippolyte/workspace/jhipster/jhipster-lite/node_modules/node/bin/node_modules/npm/bin/npm-cli.js'
[INFO] [0]     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:956:15)
[INFO] [0]     at Function.Module._load (node:internal/modules/cjs/loader:804:27)
[INFO] [0]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
[INFO] [0]     at node:internal/main/run_main_module:17:47 {
[INFO] [0]   code: 'MODULE_NOT_FOUND',
[INFO] [0]   requireStack: []
[INFO] [0] }
[INFO] [0] node:internal/modules/cjs/loader:959
[INFO] [0]   throw err;
[INFO] [0]   ^
[INFO] [0] 
[INFO] [0] Error: Cannot find module '/home/hippolyte/workspace/jhipster/jhipster-lite/node_modules/node/bin/node_modules/npm/bin/npx-cli.js'
[INFO] [0]     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:956:15)
[INFO] [0]     at Function.Module._load (node:internal/modules/cjs/loader:804:27)
[INFO] [0]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
[INFO] [0]     at node:internal/main/run_main_module:17:47 {
[INFO] [0]   code: 'MODULE_NOT_FOUND',
[INFO] [0]   requireStack: []
[INFO] [0] }
[INFO] [0] npx sass "/home/hippolyte/workspace/jhipster/jhipster-lite/src/main/style":"/home/hippolyte/workspace/jhipster/jhipster-lite/target/classes/public/style" -s compressed --source-map --embed-sources exited with code 1
[INFO] [1] /home/hippolyte/workspace/jhipster/jhipster-lite/node_modules/tikuidoc-tikui/src/documentation/style.scss => /home/hippolyte/workspace/jhipster/jhipster-lite/target/classes/public/style/documentation/style.css using SCSS
[INFO] [1] /home/hippolyte/workspace/jhipster/jhipster-lite/node_modules/prismjs/prism.js => /home/hippolyte/workspace/jhipster/jhipster-lite/target/classes/public/style/lib/prismjs/prism.js

...

[INFO] [1] /home/hippolyte/workspace/jhipster/jhipster-lite/src/main/style/template/template.pug => /home/hippolyte/workspace/jhipster/jhipster-lite/target/classes/public/style/template/template.html using Pug
[INFO] [1] node "/home/hippolyte/workspace/jhipster/jhipster-lite/node_modules/@tikui/core/dist/assets-build.js" && node "/home/hippolyte/workspace/jhipster/jhipster-lite/node_modules/@tikui/core/dist/pug-build.js" exited with code 0
[INFO] Build failed, first error code found: 1
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

any idea why?

@pascalgrimaud
Copy link
Member

@hdurix : need to clean node/ folder as suggested by @Gnuk , but I don't understand why

@Gnuk
Copy link
Collaborator Author

Gnuk commented Aug 29, 2022

I've got an error when I'm trying to build the app, for instance with ./mvnw:

[INFO] Building on /home/hippolyte/workspace/jhipster/jhipster-lite/target/classes/public/style directory.
[INFO] [0] node:internal/modules/cjs/loader:959
[INFO] [0]   throw err;
[INFO] [0]   ^
[INFO] [0] 
[INFO] [0] Error: Cannot find module '/home/hippolyte/workspace/jhipster/jhipster-lite/node_modules/node/bin/node_modules/npm/bin/npm-cli.js'
[INFO] [0]     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:956:15)
[INFO] [0]     at Function.Module._load (node:internal/modules/cjs/loader:804:27)
[INFO] [0]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
[INFO] [0]     at node:internal/main/run_main_module:17:47 {
[INFO] [0]   code: 'MODULE_NOT_FOUND',
[INFO] [0]   requireStack: []
[INFO] [0] }
[INFO] [0] node:internal/modules/cjs/loader:959
[INFO] [0]   throw err;
[INFO] [0]   ^
[INFO] [0] 
[INFO] [0] Error: Cannot find module '/home/hippolyte/workspace/jhipster/jhipster-lite/node_modules/node/bin/node_modules/npm/bin/npx-cli.js'
[INFO] [0]     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:956:15)
[INFO] [0]     at Function.Module._load (node:internal/modules/cjs/loader:804:27)
[INFO] [0]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
[INFO] [0]     at node:internal/main/run_main_module:17:47 {
[INFO] [0]   code: 'MODULE_NOT_FOUND',
[INFO] [0]   requireStack: []
[INFO] [0] }
[INFO] [0] npx sass "/home/hippolyte/workspace/jhipster/jhipster-lite/src/main/style":"/home/hippolyte/workspace/jhipster/jhipster-lite/target/classes/public/style" -s compressed --source-map --embed-sources exited with code 1
[INFO] [1] /home/hippolyte/workspace/jhipster/jhipster-lite/node_modules/tikuidoc-tikui/src/documentation/style.scss => /home/hippolyte/workspace/jhipster/jhipster-lite/target/classes/public/style/documentation/style.css using SCSS
[INFO] [1] /home/hippolyte/workspace/jhipster/jhipster-lite/node_modules/prismjs/prism.js => /home/hippolyte/workspace/jhipster/jhipster-lite/target/classes/public/style/lib/prismjs/prism.js

...

[INFO] [1] /home/hippolyte/workspace/jhipster/jhipster-lite/src/main/style/template/template.pug => /home/hippolyte/workspace/jhipster/jhipster-lite/target/classes/public/style/template/template.html using Pug
[INFO] [1] node "/home/hippolyte/workspace/jhipster/jhipster-lite/node_modules/@tikui/core/dist/assets-build.js" && node "/home/hippolyte/workspace/jhipster/jhipster-lite/node_modules/@tikui/core/dist/pug-build.js" exited with code 0
[INFO] Build failed, first error code found: 1
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

any idea why?

Yes, node directory seems not be removed with clean, maybe remove it manually then launch ./mvnw

@hdurix
Copy link
Member

hdurix commented Aug 29, 2022

better now, thanks. This may be the case for every contributors once we merge this one.

@pascalgrimaud pascalgrimaud merged commit 250d150 into jhipster:main Aug 29, 2022
@Gnuk
Copy link
Collaborator Author

Gnuk commented Aug 29, 2022

better now, thanks. This may be the case for every contributors once we merge this one.

Yes, may we need to link this PR to the contributors during this phase.

@Gnuk Gnuk deleted the style-from-tikui branch August 29, 2022 12:51
@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $100 https://www.jhipster.tech/bug-bounties/ labels Sep 2, 2022
@pascalgrimaud
Copy link
Member

Adding a bounty on this nice PR.
Plz claim it @Gnuk

@Gnuk
Copy link
Collaborator Author

Gnuk commented Sep 2, 2022

Claimed https://opencollective.com/generator-jhipster/expenses/92758

@pascalgrimaud
Copy link
Member

@Gnuk : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdurix hdurix hdurix approved these changes

@pascalgrimaud pascalgrimaud pascalgrimaud approved these changes

Assignees
No one assigned
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ generator: internal $100 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gnuk @CLAassistant @hdurix @pascalgrimaud