Sonar: 31 code smells #11042
Merged
Sonar: 31 code smells #11042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamnClin
reviewed
Oct 5, 2024
| @@ -497,15 +497,15 @@ void shouldNotDuplicateExistingProfileWithDifferentActivation() { | |||
| @Nested | |||
| class HandleAddDirectJavaDependency { | |||
|
|
|||
| private final JHipsterProjectFolder projectFolder = projectFrom("src/test/resources/projects/empty-gradle"); | |||
| private final JHipsterProjectFolder jhProjectFolder = projectFrom("src/test/resources/projects/empty-gradle"); | |||
There was a problem hiding this comment.
I don't agree with this rule, I don't think it is relevant in Java
There was a problem hiding this comment.
It don't have any issue with this rule, I think it highlights some naming clumsiness, but I don't agree with the new name which is not expressive enough.
Suggested change
| private final JHipsterProjectFolder jhProjectFolder = projectFrom("src/test/resources/projects/empty-gradle"); | |
| private final JHipsterProjectFolder emptyGradleProjectFolder = projectFrom("src/test/resources/projects/empty-gradle"); |
qmonmert
changed the title
…icating its value here
…uldAddBuildPluginToPomWithPlugins
… package should be resolved
…ages should be resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11041