feat: Upgrade and enable svelte-core module #10958

vishal423 · 2024-09-23T18:39:17Z

src/main/resources/generator/client/svelte/src/main/webapp/app.html.mustache

DamnClin · 2024-09-24T15:33:41Z

src/main/java/tech/jhipster/lite/generator/client/svelte/core/domain/SvelteModuleFactory.java

-        .addScript(scriptKey("test"), scriptCommand("npm run test:watch"))
-        .addScript(scriptKey("test:coverage"), scriptCommand("vitest run --coverage"))
-        .addScript(scriptKey("test:watch"), scriptCommand("vitest --"))
+    		.addScript(scriptKey("check"), scriptCommand("svelte-kit sync && svelte-check --tsconfig ./jsconfig.json"))


I think we should keep the script structure from angular/react/vue modules (to be able to use TikUi)

Feel free to push changes to this branch, as needed.

I won't :). Those scripts needs to be updated otherwise it will break the current work on frontend modules and we won't be able to integrate styles in svelte and svelte module will be broken, again.

I don't care about svelte integration so I won't contribute on that but I do care about frontend modules moving forward :)

@DamnClin : Don't worry, I'll take the charge of harmonizing the svelte client with other clients :) @vishal423 is helping us here to bring back the svelte client to life ;)

murdos · 2024-09-24T20:18:06Z

src/main/java/tech/jhipster/lite/generator/client/svelte/core/domain/SvelteModuleFactory.java

  public JHipsterModule buildSvelteModule(JHipsterModuleProperties properties) {
    Assert.notNull("properties", properties);

    //@formatter:off
    return moduleBuilder(properties)
-      .preCommitActions(stagedFilesFilter("{src/**/,}*.ts"), preCommitCommands("eslint --fix", "prettier --write"))


I think we should keep typescript.
Enforcing a strongly typed language, that allows Type Driven Development, is one of the opinionated view of jhipster-lite.

feel free to push changes, as needed

murdos · 2024-09-24T20:19:21Z

src/main/java/tech/jhipster/lite/generator/client/svelte/core/domain/SvelteModuleFactory.java

  public JHipsterModule buildSvelteModule(JHipsterModuleProperties properties) {
    Assert.notNull("properties", properties);

    //@formatter:off
    return moduleBuilder(properties)
-      .preCommitActions(stagedFilesFilter("{src/**/,}*.ts"), preCommitCommands("eslint --fix", "prettier --write"))
+      .preCommitActions(stagedFilesFilter("{src/**/,}*.{js,svelte}"), preCommitCommands("eslint --fix", "prettier --write", "npm run check"))


On other client in jhipster-lite, the pre-commit action doesn't check, it just fixes/reformat.

invocation of eslint --fix implicitly checks for lint errors and resolves whatever it can. If you still have lint errors, then, I believe it print those on console and aborts the commit. Inclusion of svelte check is to avoid commit of erroneous svelte code.

murdos · 2024-09-24T20:52:45Z

src/main/java/tech/jhipster/lite/generator/client/svelte/core/domain/SvelteModuleFactory.java

-        .addScript(scriptKey("test:watch"), scriptCommand("vitest --"))
+    		.addScript(scriptKey("check"), scriptCommand("svelte-kit sync && svelte-check --tsconfig ./jsconfig.json"))
+        .addScript(scriptKey("lint"), scriptCommand("prettier --check . && eslint ."))
+        .addScript(scriptKey("format"), scriptCommand("prettier --write '{,src/**/,cypress/**/}*.{md,json,js,cjs,svelte,css,html,yml}'"))


The svelte module already depends on the prettier module, that setup a prettier:format script, so there's no need to add a new script for formatting.

Since we use a different pattern in pre-commit hook, this script allows reuse of same for explicit invocation

src/main/java/tech/jhipster/lite/generator/client/svelte/core/domain/SvelteModuleFactory.java

murdos · 2024-09-24T21:12:16Z

src/main/java/tech/jhipster/lite/generator/client/svelte/core/domain/SvelteModuleFactory.java

@@ -17,96 +18,108 @@ public class SvelteModuleFactory {

  private static final String ENGINES_NEEDLE = "  \"engines\":";

-  private static final JHipsterSource PRIMARY_MAIN_SOURCE = SOURCE.append("src/main/webapp/app/common/primary/app");
-  private static final JHipsterDestination PRIMARY_MAIN_DESTINATION = to("src/main/webapp/app/common/primary/app");
+  private static final JHipsterSource PRIMARY_MAIN_SOURCE = SOURCE.append("src/main/webapp/lib/common/primary/app");


I think we should keep things in the app folder: other modules (e.g. ts-pagination-domainà that generates additional content will generate content in the app folder.

technically it's internal lib containing app specific components. feel free to update, if needed

src/main/java/tech/jhipster/lite/generator/client/svelte/core/domain/SvelteModuleFactory.java

….html.mustache Co-authored-by: Quentin <[email protected]>

…domain/SvelteModuleFactory.java Co-authored-by: Aurélien Mino <[email protected]>

…t has been added to prettier module

github-actions bot added the area: triage label Sep 23, 2024

vishal423 marked this pull request as ready for review September 24, 2024 05:46

qmonmert reviewed Sep 24, 2024

View reviewed changes

src/main/resources/generator/client/svelte/src/main/webapp/app.html.mustache Outdated Show resolved Hide resolved

DamnClin reviewed Sep 24, 2024

View reviewed changes

murdos reviewed Sep 24, 2024

View reviewed changes

murdos added area: feature request 💡 client: svelte theme: client and removed area: triage labels Sep 25, 2024

vishal423 and others added 9 commits October 2, 2024 23:51

feat: Upgrade and enable svelte-core module

13619d7

fix lint errors

dff0c21

fix svelte feature test

f6e75a1

Fix sonar violation

6a79f06

Update src/main/resources/generator/client/svelte/src/main/webapp/app…

4fd7e0b

….html.mustache Co-authored-by: Quentin <[email protected]>

Update src/main/java/tech/jhipster/lite/generator/client/svelte/core/…

8817e63

…domain/SvelteModuleFactory.java Co-authored-by: Aurélien Mino <[email protected]>

fix(svelte): factory code was not compiling anymore

9a02431

refactor(svelte): reuse npm dependencies from common source

0b9de52

chore(svelte): remove prettier-plugin-organize-imports from svelte, i…

03d014d

…t has been added to prettier module

murdos force-pushed the enable-svelte-module branch from 4e12210 to 03d014d Compare October 2, 2024 21:55

ci(svelte): add svelte to github actions tests

11885b4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Upgrade and enable svelte-core module #10958

feat: Upgrade and enable svelte-core module #10958

vishal423 commented Sep 23, 2024

DamnClin Sep 24, 2024

vishal423 Sep 24, 2024

DamnClin Sep 26, 2024

murdos Sep 26, 2024

murdos Sep 24, 2024

vishal423 Sep 25, 2024

murdos Sep 24, 2024

vishal423 Sep 25, 2024

murdos Sep 24, 2024

vishal423 Sep 25, 2024

murdos Sep 24, 2024

vishal423 Sep 25, 2024

feat: Upgrade and enable svelte-core module #10958

Are you sure you want to change the base?

feat: Upgrade and enable svelte-core module #10958

Conversation

vishal423 commented Sep 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment