Update vue-core vitest configuration and sonar properties for front #10833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pascalgrimaud
commented
Sep 14, 2024
pascalgrimaud
commented
- fix vue-core module and coverage #10822
|
@pascalgrimaud I added tests for HomeRouter #10835 but if it is unused qou can close the PR |
DamnClin
reviewed
Sep 14, 2024
| @@ -17,7 +17,14 @@ sonar.testExecutionReportPaths={{projectBuildDirectory}}/test-results/TESTS-resu | |||
| sonar.javascript.lcov.reportPaths={{projectBuildDirectory}}/test-results/lcov.info | |||
|
|
|||
| sonar.sourceEncoding=UTF-8 | |||
| sonar.exclusions=src/main/webapp/main.ts, src/main/webapp/app/main.ts, src/main/webapp/content/**/*.*, {{projectBuildDirectory}}/classes/static/**/*.*, src/main/webapp/app/index.tsx | |||
| sonar.exclusions=\ | |||
| src/main/webapp/app/home/infrastructure/primary/*.*,\ | |||
There was a problem hiding this comment.
All infrastructure code, from all contextes, should be excluded since we can't get proper metrics on that
There was a problem hiding this comment.
In fact, since we can't merge coverrages in front it not a good idea to add a threshold. It will force people to make implementation details tests just to make CI pass
There was a problem hiding this comment.
I agree on that, but as I'm really short on time.
So I'll keep this like this:
- so I can do a patch release, fixing the deploy on GCP
- the coverage will be back at 100% on sample app
- then, someone can work on this for the next version v1.19.0
- clean tests on infrastructure
- update sonar properties propertly
- keep consistency between angular / react / vue
There was a problem hiding this comment.
I'll create a dedicated ticket for that -> #10836
pascalgrimaud
force-pushed
the
10822/vue-core-update-vitest-config
branch
from
bf482d9
to
1b43990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.