add vue internationalization #10690
Merged
add vue internationalization #10690
+466
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
setupTest to be done in the react module in order to not mock i18next on each test |
fabienpuissant
force-pushed
the
feature/vue-internationalization
branch
2 times, most recently
from
b236543
to
a628c18
Compare
murdos
added
area: feature request 💡
client: vue
theme: client
and removed
area: triage
labels
DamnClin
reviewed
Aug 31, 2024
src/main/resources/generator/client/vue/i18n/src/main/webapp/app/i18n.ts
Outdated
Show resolved
Hide resolved
fabienpuissant
force-pushed
the
feature/vue-internationalization
branch
4 times, most recently
from
501c7fb
to
ec116df
Compare
fabienpuissant
force-pushed
the
feature/vue-internationalization
branch
3 times, most recently
from
2d214da
to
4a0d5ec
Compare
fabienpuissant
force-pushed
the
feature/vue-internationalization
branch
from
4a0d5ec
to
c17c89c
Compare
Gnuk
reviewed
Sep 6, 2024
src/main/resources/generator/client/common/i18n/Translations.ts
Outdated
Show resolved
Hide resolved
fabienpuissant
force-pushed
the
feature/vue-internationalization
branch
from
c17c89c
to
db74bb8
Compare
DamnClin
previously approved these changes
Sep 22, 2024
create vue internalization module using i18next 23.14.0 with language detector see https://i18next.github.io/i18next-vue/introduction.html
fabienpuissant
force-pushed
the
feature/vue-internationalization
branch
2 times, most recently
from
b466c4a
to
f47356e
Compare
|
@murdos |
murdos
reviewed
Sep 27, 2024
| .containing(nodeDependency("i18next-browser-languagedetector")) | ||
| .and() | ||
| .hasFile("src/main/webapp/app/i18n.ts") | ||
| .containing( |
There was a problem hiding this comment.
There's no real need to check the content of your templates.
It's more useful when you're modifying an existing file.
There was a problem hiding this comment.
Ok then I removed also for the i18n files related since they are not templated we just load the file into the app (fr.ts, en.ts, Translations.ts, test file)
fabienpuissant
force-pushed
the
feature/vue-internationalization
branch
from
f47356e
to
6475496
Compare
|
Thanks @fabienpuissant ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create vue internalization module using i18next 23.14.0 with language detector see https://i18next.github.io/i18next-vue/introduction.html