Merge pull request #11284 from qmonmert/deprecatedcodeapps

Sonar: reactivate rule on generated apps - Deprecated code should be removed
jhipster · Nov 4, 2024 · b698153 · b698153
2 parents b329294 + 79d879a
commit b698153
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/src/main/resources/generator/server/sonar/sonar-fullstack-project.properties.mustache b/src/main/resources/generator/server/sonar/sonar-fullstack-project.properties.mustache
@@ -25,7 +25,7 @@ sonar.exclusions=\
   src/main/webapp/app/index.tsx,\
   src/main/webapp/main.ts
 
-sonar.issue.ignore.multicriteria=S117,S119,S125_1,S125_2,S3437,S4502,S4684,S4032,S5778,S1133,S6206,S6437,S6564,UndocumentedApi,S2301,S7027
+sonar.issue.ignore.multicriteria=S117,S119,S125_1,S125_2,S3437,S4502,S4684,S4032,S5778,S6206,S6437,S6564,UndocumentedApi,S2301,S7027
 
 # Rule: Local variable and method parameter names should comply with a naming convention
 # Handled with checkstyle. Should be revisited with java 25 once Unnamed Patterns and Variables are available (JEP 443)
@@ -60,10 +60,6 @@ sonar.issue.ignore.multicriteria.S4032.ruleKey=java:S4032
 sonar.issue.ignore.multicriteria.S5778.resourceKey=src/test/java/**/*
 sonar.issue.ignore.multicriteria.S5778.ruleKey=java:S5778
 
-# Rule: Deprecated code should be removed
-sonar.issue.ignore.multicriteria.S1133.resourceKey=src/main/java/**/*
-sonar.issue.ignore.multicriteria.S1133.ruleKey=java:S1133
-
 # Rule: Use record when possible in primary
 sonar.issue.ignore.multicriteria.S6206.resourceKey=src/main/java/**/infrastructure/primary/**/*
 sonar.issue.ignore.multicriteria.S6206.ruleKey=java:S6206

diff --git a/src/main/resources/generator/server/sonar/sonar-project.properties.mustache b/src/main/resources/generator/server/sonar/sonar-project.properties.mustache
@@ -21,7 +21,7 @@ sonar.exclusions=\
   src/main/webapp/app/index.tsx,\
   src/main/webapp/main.ts
 
-sonar.issue.ignore.multicriteria=S117,S119,S125_1,S125_2,S3437,S4502,S4684,S4032,S5778,S1133,S6206,S6548,S6437,S6471,UndocumentedApi,S2301,S7027
+sonar.issue.ignore.multicriteria=S117,S119,S125_1,S125_2,S3437,S4502,S4684,S4032,S5778,S6206,S6548,S6437,S6471,UndocumentedApi,S2301,S7027
 
 # Rule: Local variable and method parameter names should comply with a naming convention
 # Handled with checkstyle. Should be revisited with java 25 once Unnamed Patterns and Variables are available (JEP 443)
@@ -56,10 +56,6 @@ sonar.issue.ignore.multicriteria.S4032.ruleKey=java:S4032
 sonar.issue.ignore.multicriteria.S5778.resourceKey=src/test/java/**/*
 sonar.issue.ignore.multicriteria.S5778.ruleKey=java:S5778
 
-# Rule: Deprecated code should be removed
-sonar.issue.ignore.multicriteria.S1133.resourceKey=src/main/java/**/*
-sonar.issue.ignore.multicriteria.S1133.ruleKey=java:S1133
-
 # Rule: Use record when possible in primary
 sonar.issue.ignore.multicriteria.S6206.resourceKey=src/main/java/**/infrastructure/primary/**/*
 sonar.issue.ignore.multicriteria.S6206.ruleKey=java:S6206